Thanks Jake, I believe this should be acceptable but some IPMCs may ask about it since most of them have similar check like I do
- Henry On Mon, May 5, 2014 at 3:51 PM, Jake Farrell <jfarr...@apache.org> wrote: > Hey Henry > Wanted to follow up to Kevin's comments with the gradle.jar is initially > added via the build.gradle 'wrapper' task which downloads and keeps that > jar up to date so it will always match the version we have configured. This > is the only binary file in the source package and there is current > precedence from other TLP's which leave this file in the source dist, one > example is Apache Kafka. > > -Jake > > > > > On Mon, May 5, 2014 at 6:47 PM, Henry Saputra <henry.sapu...@gmail.com>wrote: > >> Cool, thanks! >> >> - Henry >> >> On Mon, May 5, 2014 at 3:18 PM, Kevin Sweeney <kevi...@apache.org> wrote: >> > It's generated by the gradle wrapper task. Documentation [1] states: >> > >> > Build layout >> > >> > simple/ >> > gradlew >> > gradlew.bat >> > gradle/wrapper/ >> > gradle-wrapper.jar >> > gradle-wrapper.properties >> > >> > All of these files *should* be submitted to your version control system. >> > This only needs to be done once. After these files have been added to the >> > project, the project should then be built with the added *gradlew* >> command. >> > The *gradlew* command can be used *exactly* the same way as the *gradle * >> > command. >> > [1] http://www.gradle.org/docs/current/userguide/gradle_wrapper.html >> > >> > >> > On Mon, May 5, 2014 at 2:35 PM, Henry Saputra <henry.sapu...@gmail.com >> >wrote: >> > >> >> There is a jar file inside the source artifact [1]. Is this jar >> >> generated from source code or "executable" copied from external >> >> source? >> >> >> >> >> >> Thanks, >> >> >> >> Henry >> >> >> >> >> >> [1] gradle/wrapper/gradle-wrapper.jar >> >> >> >> On Mon, May 5, 2014 at 10:57 AM, Kevin Sweeney <kevi...@apache.org> >> wrote: >> >> > All, >> >> > I propose that we accept the following release candidate as the >> official >> >> > Apache Aurora 0.5.0 release. >> >> > >> >> > >> >> > Aurora 0.5.0-rc0 includes the following: >> >> > --- >> >> > The CHANGELOG for the release is available at: >> >> > >> >> >> https://git-wip-us.apache.org/repos/asf?p=incubator-aurora.git;a=blob_plain;f=CHANGELOG;hb=0.5.0-rc0 >> >> > >> >> > The branch used to create the release with is 0.5.0-rc0: >> >> > >> >> >> https://git-wip-us.apache.org/repos/asf?p=incubator-aurora.git;a=tree;hb=0.5.0-rc0 >> >> > >> >> > The release candidate is available at: >> >> > >> >> >> https://dist.apache.org/repos/dist/dev/incubator/aurora/0.5.0-rc0/aurora-0.5.0-rc0-incubating.tar.gz >> >> > >> >> > The MD5 checksum of the release candidate can be found at: >> >> > >> >> >> https://dist.apache.org/repos/dist/dev/incubator/aurora/0.5.0-rc0/aurora-0.5.0-rc0-incubating.tar.gz.md5 >> >> > >> >> > The signature of the release candidate can be found at: >> >> > >> >> >> https://dist.apache.org/repos/dist/dev/incubator/aurora/0.5.0-rc0/aurora-0.5.0-rc0-incubating.tar.gz.asc >> >> > >> >> > The GPG key used to sign the release are available at: >> >> > https://dist.apache.org/repos/dist/dev/incubator/aurora/KEYS >> >> > >> >> > Please download, verify, and test. >> >> > >> >> > The vote will close on >> >> > >> >> > [ ] +1 Release this as Apache Aurora 0.5.0 >> >> > [ ] +0 >> >> > [ ] -1 Do not release this as Apache Aurora 0.5.0 becuase... >> >> >>
