> On Dec. 16, 2013, 5:58 p.m., Maxim Khutornenko wrote: > > src/main/java/com/twitter/aurora/scheduler/periodic/GcExecutorLauncher.java, > > line 115 > > <https://reviews.apache.org/r/16247/diff/1/?file=397622#file397622line115> > > > > That was my original idea but I did not feel comfortable adding a state > > mutating operation behind a read-like isAlive() call. I can do it if you > > feel strong about it though.
I feel semi-strongly about pushing the complexity down if we can. Maybe a different verb? Another option worth weighing is collapsing PulseMonitor back into GcExecutorLauncher. It used to have more use cases, but now there's only one. Given that the bulk of PulseMonitor.java is currently wiring, docs, and boilerplate — this might be the best option. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16247/#review30452 ----------------------------------------------------------- On Dec. 16, 2013, 6:06 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16247/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2013, 6:06 p.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Modified PulseMonitor to support random initial jitter delay. > > > Diffs > ----- > > src/main/java/com/twitter/aurora/scheduler/PulseMonitor.java > e31ce3d71c895f43ff73ad8e904124443ebdd72a > src/main/java/com/twitter/aurora/scheduler/SchedulerModule.java > bd7929d631cf45b4c2c7f39177bbafbd8f659071 > src/main/java/com/twitter/aurora/scheduler/periodic/GcExecutorLauncher.java > 5a8e13f0d719052286a7136707d7ed1aca87bab2 > src/test/java/com/twitter/aurora/scheduler/PulseMonitorImplTest.java > PRE-CREATION > > src/test/java/com/twitter/aurora/scheduler/periodic/GcExecutorLauncherTest.java > ac5e3102925e2f26a12e18e95817403d18e25cb3 > > Diff: https://reviews.apache.org/r/16247/diff/ > > > Testing > ------- > > gradle build > > > Thanks, > > Maxim Khutornenko > >
