----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16247/#review30452 -----------------------------------------------------------
src/main/java/com/twitter/aurora/scheduler/PulseMonitor.java <https://reviews.apache.org/r/16247/#comment58251> Done. src/main/java/com/twitter/aurora/scheduler/PulseMonitor.java <https://reviews.apache.org/r/16247/#comment58252> Leftover from original implementation. Fixed. src/main/java/com/twitter/aurora/scheduler/PulseMonitor.java <https://reviews.apache.org/r/16247/#comment58253> Done. src/main/java/com/twitter/aurora/scheduler/SchedulerModule.java <https://reviews.apache.org/r/16247/#comment58250> Done. src/main/java/com/twitter/aurora/scheduler/periodic/GcExecutorLauncher.java <https://reviews.apache.org/r/16247/#comment58254> That was my original idea but I did not feel comfortable adding a state mutating operation behind a read-like isAlive() call. I can do it if you feel strong about it though. - Maxim Khutornenko On Dec. 13, 2013, 6:39 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16247/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2013, 6:39 p.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Modified PulseMonitor to support random initial jitter delay. > > > Diffs > ----- > > src/main/java/com/twitter/aurora/scheduler/PulseMonitor.java > e31ce3d71c895f43ff73ad8e904124443ebdd72a > src/main/java/com/twitter/aurora/scheduler/SchedulerModule.java > bd7929d631cf45b4c2c7f39177bbafbd8f659071 > src/main/java/com/twitter/aurora/scheduler/periodic/GcExecutorLauncher.java > 5a8e13f0d719052286a7136707d7ed1aca87bab2 > src/test/java/com/twitter/aurora/scheduler/PulseMonitorImplTest.java > PRE-CREATION > > src/test/java/com/twitter/aurora/scheduler/periodic/GcExecutorLauncherTest.java > ac5e3102925e2f26a12e18e95817403d18e25cb3 > > Diff: https://reviews.apache.org/r/16247/diff/ > > > Testing > ------- > > gradle build > > > Thanks, > > Maxim Khutornenko > >
