Brijesh619 commented on code in PR #721: URL: https://github.com/apache/atlas/pull/721#discussion_r3933483450
########## 3party-licenses/bootstrap-LICENSE: ########## @@ -0,0 +1,22 @@ +The MIT License (MIT) Review Comment: I have resolved the issue mentioned in the comment. The missing directory error when skipEnunciate=true is fixed, and I have confirmed there are zero CDN references after building. I also fixed a deprecation warning in the maven-antrun-plugin by replacing <tasks> with <target>. Let me know if there's anything else you'd like me to look at! ########## docs/crypto-fallback.js: ########## @@ -0,0 +1,40 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +const crypto = require("crypto"); +const originalCreateHash = crypto.createHash; + +crypto.createHash = (algorithm, options) => { + if (algorithm === "md4") { + try { + return originalCreateHash("md4", options); + } catch (e) { + return originalCreateHash("sha256", options); + } + } + return originalCreateHash(algorithm, options); +}; + +process.on("uncaughtException", function (err) { Review Comment: I have removed the global uncaughtException handler that was swallowing all ECONNRESET exceptions in docs/crypto-fallback.js, as requested in the PR comment. Let me know if there's any other feedback from the PR that needs to be addressed! ########## docs/crypto-fallback.js: ########## @@ -0,0 +1,40 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +const crypto = require("crypto"); +const originalCreateHash = crypto.createHash; + +crypto.createHash = (algorithm, options) => { Review Comment: I have added a documentation comment above the crypto.createHash override in docs/crypto-fallback.js that explains why the md4 → sha256 fallback is safe for Webpack content hashing, addressing the feedback from the PR comment. Let me know if you need any further modifications! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
