Brijesh619 commented on code in PR #721:
URL: https://github.com/apache/atlas/pull/721#discussion_r3927977565
##########
webapp/pom.xml:
##########
@@ -683,6 +683,38 @@
</tasks>
</configuration>
</execution>
+ <execution>
+ <id>fix-enunciate-css</id>
+ <goals>
+ <goal>run</goal>
+ </goals>
+ <phase>prepare-package</phase>
Review Comment:
Addressed. Added <skip>${skipEnunciate}</skip> to the fix-enunciate-css
execution configuration in webapp/pom.xml. The antrun execution will now
automatically be skipped when Enunciate documentation generation is skipped via
-DskipEnunciate=true.
##########
webapp/pom.xml:
##########
@@ -683,6 +683,38 @@
</tasks>
</configuration>
</execution>
+ <execution>
+ <id>fix-enunciate-css</id>
+ <goals>
+ <goal>run</goal>
+ </goals>
+ <phase>prepare-package</phase>
+ <configuration>
+ <tasks>
+ <!-- Copy CSS -->
+ <copy failonerror="false"
file="${project.basedir}/src/main/enunciate-assets/css/bootstrap.min.css"
todir="${project.build.directory}/api/v2/css" />
Review Comment:
Addressed. Consolidated the 15 individual <copy> tasks in webapp/pom.xml
into directory-level <fileset> copy tasks for enunciate-assets/css and
enunciate-assets/js. This significantly reduces boilerplate and simplifies
maintaining asset dependencies.
##########
webapp/src/main/enunciate-assets/js/run_prettify.js:
##########
@@ -0,0 +1,64 @@
+!function(){/*
Review Comment:
Addressed. Added documentation comments in webapp/pom.xml and in the header
of webapp/src/main/enunciate-assets/js/jquery-1.12.2.min.js clarifying that
jQuery 1.12.2 is pinned strictly for compatibility with Bootstrap 3.4.1 within
static Enunciate REST API documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
