Sorry to be late chiming in, but +1 from me. I also have a PR up for the Julia implementation to support the new decimal bitwidths: https://github.com/apache/arrow-julia/pull/525
If there are JSON integration test files that are being updated/included somewhere, I'd love to incorporate them into the existing tests we do for those on the Julia side. -Jacob On Fri, Sep 6, 2024 at 1:46 PM Matt Topol <zotthewiz...@gmail.com> wrote: > The vote passes with 5 +1 binding votes, 4 +1 non-binding votes, and no -1 > votes. > > Binding Votes: > Wes > Antoine > Kou > Joris > Matt > > Non-binding Votes > Curt > Felipe > Gang > Ruoxi > > Thanks everyone! > > The PRs can be merged once they are reviewed and approved, which will > update the documentation. > > --Matt > > > On Fri, Sep 6, 2024 at 2:55 PM Ruoxi Sun <zanmato1...@gmail.com> wrote: > > > +1 (non-bonding). > > > > Thanks. > > > > *Regards,* > > *Rossi SUN* > > > > > > Joris Van den Bossche <jorisvandenboss...@gmail.com>于2024年9月6日 > 周五14:46写道： > > > > > +1 (binding) > > > > > > On Fri, 6 Sept 2024 at 03:57, Gang Wu <ust...@gmail.com> wrote: > > > > > > > > +1 (non-binding) > > > > > > > > On Fri, Sep 6, 2024 at 3:57 AM Sutou Kouhei <k...@clear-code.com> > > wrote: > > > > > > > > > +1 (binding) > > > > > > > > > > In < > > cah4123zv0ph37hrufui1oejzddt3+fwkturk1unpsjmrzuk...@mail.gmail.com > > > > > > > > > "[VOTE] Allow Decimal32 and Decimal64 bitwidths in Arrow Format" > on > > > Wed, > > > > > 4 Sep 2024 17:17:49 -0400, > > > > > Matt Topol <zotthewiz...@gmail.com> wrote: > > > > > > > > > > > Based on various discussions among the ecosystem and to continue > > > > > expanding > > > > > > the zero-copy interoperability for Arrow to be used with > different > > > > > > libraries and databases (such as libcudf, ClickHouse, etc) I > would > > > like > > > > > to > > > > > > propose that we extend the allowable bit-widths for Arrow Decimal > > > types > > > > > to > > > > > > allow 32-bit and 64-bit decimals. > > > > > > > > > > > > The Arrow Spec currently defines the Decimal type as a > > parameterized > > > > > type, > > > > > > parameterized by the bit-width, and then just specifies that the > > only > > > > > > allowed bitwidths are 128 and 256. Thus, rather than adding an > > > entirely > > > > > new > > > > > > type we could simply expand what is allowed for the bitwidth > field > > > which > > > > > > makes the format side of this a very small change. > > > > > > > > > > > > I've uploaded a PR for adding support for this to C++ [1] and > will > > be > > > > > > uploading a PR for a corresponding Go change within the next day > > and > > > will > > > > > > respond to this thread with the link. > > > > > > > > > > > > The vote will be open for at least 72 hours. > > > > > > > > > > > > [ ] +1 - Update the Arrow Spec to allow for 32-bit and 64-bit > > > bitwidths > > > > > for > > > > > > Arrow Decimal types > > > > > > [ ] +0 > > > > > > [ ] -1 - Do not update the Arrow Spec to allow for 32-bit and > > 64-bit > > > > > > bitwidths for Arrow Decimal types because.... > > > > > > > > > > > > Thanks everyone! > > > > > > > > > > > > --Matt > > > > > > > > > > > > [1]: https://github.com/apache/arrow/pull/43957 > > > > > > > > > > >
