+1 (non-binding) Micah Kornfield, you have a good point. One spec without at least 2 implementations is not a serious spec.
But I think we can run the vote now and defer the merging of the implementations until we are confident both implementations are almost complete, tested and the spec text covers all the details (e.g. limits of precision for each decimal type). The code review for the C++ implementation alone is likely to take a significant amount of time. -- Felipe On Wed, Sep 4, 2024 at 6:51 PM Micah Kornfield <emkornfi...@gmail.com> wrote: > Could we maybe hold off on the vote until we have the second > implementation? I think we are agreed in practice the we should allow these > types but I'm not sure I understand the urgency here not to wait for the > second implementation (and add integration tests between the two?) > > On Wed, Sep 4, 2024 at 2:47 PM Curt Hagenlocher <c...@hagenlocher.org> > wrote: > > > +1 (non-binding) > > > > I can upload a PR for the corresponding C# change within the next day. > > > > On Wed, Sep 4, 2024 at 2:21 PM Matt Topol <zotthewiz...@gmail.com> > wrote: > > > > > Based on various discussions among the ecosystem and to continue > > expanding > > > the zero-copy interoperability for Arrow to be used with different > > > libraries and databases (such as libcudf, ClickHouse, etc) I would like > > to > > > propose that we extend the allowable bit-widths for Arrow Decimal types > > to > > > allow 32-bit and 64-bit decimals. > > > > > > The Arrow Spec currently defines the Decimal type as a parameterized > > type, > > > parameterized by the bit-width, and then just specifies that the only > > > allowed bitwidths are 128 and 256. Thus, rather than adding an entirely > > new > > > type we could simply expand what is allowed for the bitwidth field > which > > > makes the format side of this a very small change. > > > > > > I've uploaded a PR for adding support for this to C++ [1] and will be > > > uploading a PR for a corresponding Go change within the next day and > will > > > respond to this thread with the link. > > > > > > The vote will be open for at least 72 hours. > > > > > > [ ] +1 - Update the Arrow Spec to allow for 32-bit and 64-bit bitwidths > > for > > > Arrow Decimal types > > > [ ] +0 > > > [ ] -1 - Do not update the Arrow Spec to allow for 32-bit and 64-bit > > > bitwidths for Arrow Decimal types because.... > > > > > > Thanks everyone! > > > > > > --Matt > > > > > > [1]: https://github.com/apache/arrow/pull/43957 > > > > > >
