+1 (non binding) It sounds good to me. Maybe with to update documentation ?
Thanks Regards JB On Wed, Apr 3, 2024 at 1:01 PM Joel Lubinitsky <joell...@gmail.com> wrote: > > Hello, > > I would like to propose a change to the ADBC specification that introduces > 5 new standard info codes and formalizes 3 existing option keys. > > The info codes being introduced are: > - ADBC_INFO_VENDOR_READ_ONLY 3 > - ADBC_INFO_VENDOR_SQL 4 > - ADBC_INFO_VENDOR_SUBSTRAIT 5 > - ADBC_INFO_VENDOR_SUBSTRAIT_MIN_VERSION 6 > - ADBC_INFO_VENDOR_SUBSTRAIT_MAX_VERSION 7 > > The option keys have been in use (defined in options.h) and are being moved > to adbc.h: > - ADBC_INGEST_OPTION_TARGET_CATALOG "adbc.ingest.target_catalog" > - ADBC_INGEST_OPTION_TARGET_DB_SCHEMA "adbc.ingest.target_db_schema" > - ADBC_INGEST_OPTION_TEMPORARY "adbc.ingest.temporary" > > The change is described in this issue [0] and an implementation is included > in this PR [1]. > > The vote will be open for at least 72 hours. > > [ ] +1 Add these info codes and options keys to the ADBC spec > [ ] +0 > [ ] -1 Do not add these to the ADBC spec because... > > Thanks, > Joel > > [0]: https://github.com/apache/arrow-adbc/issues/1650 > [1]: https://github.com/apache/arrow-adbc/pull/1649
