Yes, just updated both the issue and the PR. Thanks, Joel
On Fri, Apr 5, 2024 at 7:51 PM Sutou Kouhei <k...@clear-code.com> wrote: > +1 > > Could you also update the description of > https://github.com/apache/arrow-adbc/issues/1650 ? > > Thanks, > -- > kou > > In <pony-b708893b-b770-41d4-a583-4d3c04332fcd-...@arrow.apache.org> > "Re: [VOTE] Add new info codes and options keys to ADBC specification" > on Fri, 05 Apr 2024 15:39:33 -0000, > Joel Lubinitsky <joell...@apache.org> wrote: > > > Update on this: > > > > I've removed ADBC_INFO_VENDOR_READ_ONLY from the proposal. The change is > reflected in this commit [1] on the original PR [2]. The numbers > corresponding to each of the other info codes have been decremented by 1 to > fill the gap in numbering. > > > > The reason is that a similar option already exists via > ConnectionGet/SetOptions, so defining it on the driver isn't helpful. > > > > [1]: > https://github.com/apache/arrow-adbc/pull/1649/commits/a52a4fa16e6b740392d3617751e28f044f1a8325 > > [2]: https://github.com/apache/arrow-adbc/pull/1649 > > > > Thanks, > > Joel > > > > On 2024/04/03 11:01:13 Joel Lubinitsky wrote: > >> Hello, > >> > >> I would like to propose a change to the ADBC specification that > introduces > >> 5 new standard info codes and formalizes 3 existing option keys. > >> > >> The info codes being introduced are: > >> - ADBC_INFO_VENDOR_READ_ONLY 3 > >> - ADBC_INFO_VENDOR_SQL 4 > >> - ADBC_INFO_VENDOR_SUBSTRAIT 5 > >> - ADBC_INFO_VENDOR_SUBSTRAIT_MIN_VERSION 6 > >> - ADBC_INFO_VENDOR_SUBSTRAIT_MAX_VERSION 7 > >> > >> The option keys have been in use (defined in options.h) and are being > moved > >> to adbc.h: > >> - ADBC_INGEST_OPTION_TARGET_CATALOG "adbc.ingest.target_catalog" > >> - ADBC_INGEST_OPTION_TARGET_DB_SCHEMA "adbc.ingest.target_db_schema" > >> - ADBC_INGEST_OPTION_TEMPORARY "adbc.ingest.temporary" > >> > >> The change is described in this issue [0] and an implementation is > included > >> in this PR [1]. > >> > >> The vote will be open for at least 72 hours. > >> > >> [ ] +1 Add these info codes and options keys to the ADBC spec > >> [ ] +0 > >> [ ] -1 Do not add these to the ADBC spec because... > >> > >> Thanks, > >> Joel > >> > >> [0]: https://github.com/apache/arrow-adbc/issues/1650 > >> [1]: https://github.com/apache/arrow-adbc/pull/1649 > >> >
