With PR#430 <https://github.com/apache/arrow-julia/pull/430> merged I can now give my +1 vote for this release.
On Fri, Apr 14, 2023 at 8:24 PM Ben Baumgold <b...@baumgold.com> wrote: > I made Issue #49 <https://github.com/apache/arrow-julia/issues/429> for > this bug and created PR#430 > <https://github.com/apache/arrow-julia/pull/430> as a proposed solution. > > On Wed, Apr 12, 2023 at 7:57 PM Ben Baumgold <baumg...@apache.org> wrote: > >> I saw the same issue on my M1 Mac with Julia v1.8.5. All tests pass >> successfully on my x86_64 GNU/Linux box with Julia v1.8.5. >> >> On 2023/04/12 17:26:20 Eric Hanson wrote: >> > I saw the same issue, on Julia 1.8.5, macOS m1. I tried Rosetta as well >> and got a different error: >> https://github.com/apache/arrow-julia/issues/425 >> > >> > On 2023/04/12 07:10:14 David Li wrote: >> > > I was able to reproduce it just now, with the same error. If there's >> a patch I can apply or a flag I can set, I'm happy to give it a run in the >> AM. >> > > >> > > On Wed, Apr 12, 2023, at 10:02, Jacob Quinn wrote: >> > > > Hmmm, I'm also on MacOS m1, but didn't have any issues running >> tests. >> > > > >> > > > David, is the error reproducible? We fixed an issue for this in >> [this >> > > > commit]( >> > > > >> https://github.com/apache/arrow-julia/commit/6d0ac4946f062414e2b60aa3d67c2875bb2e7958 >> ), >> > > > but it's possible that our check for this condition wasn't strong >> > > > enough or >> > > > something. If it's reproducible, I'd appreciate being able to do a >> debug >> > > > build for you and have it report some data around our check for >> this. >> > > > >> > > > -Jacob >> > > > >> > > > On Tue, Apr 11, 2023 at 6:36 PM David Li <lidav...@apache.org> >> wrote: >> > > > >> > > >> I had an issue during verification (macOS/AArch64) [1] >> > > >> >> > > >> The gist seems to be: >> > > >> >> > > >> ``` >> > > >> nested task error: ArgumentError: unsafe_wrap: pointer >> 0x293389438 >> > > >> is not properly aligned to 16 bytes >> > > >> Stacktrace: >> > > >> [1] #unsafe_wrap#100 >> > > >> @ ./pointer.jl:92 [inlined] >> > > >> [2] unsafe_wrap >> > > >> @ ./pointer.jl:90 [inlined] >> > > >> [3] reinterp(#unused#::Type{Arrow.Decimal{2, 2, Int128}}, >> > > >> batch::Arrow.Batch, buf::Arrow.Flatbuf.Buffer, >> > > >> compression::Arrow.Flatbuf.BodyCompression) >> > > >> @ Arrow >> > > >> >> ~/Code/arrow-julia/verification/apache-arrow-julia-2.5.1/src/table.jl:557 >> > > >> [4] build(f::Arrow.Flatbuf.Field, >> #unused#::Arrow.Flatbuf.Decimal, >> > > >> batch::Arrow.Batch, rb::Arrow.Flatbuf.RecordBatch, de::Dict{Int64, >> > > >> Arrow.DictEncoding}, nodeidx::Int64, bufferidx::Int64, >> convert::Bool) >> > > >> @ Arrow >> > > >> >> ~/Code/arrow-julia/verification/apache-arrow-julia-2.5.1/src/table.jl:685 >> > > >> [5] build(field::Arrow.Flatbuf.Field, batch::Arrow.Batch, >> > > >> rb::Arrow.Flatbuf.RecordBatch, de::Dict{Int64, Arrow.DictEncoding}, >> > > >> nodeidx::Int64, bufferidx::Int64, convert::Bool) >> > > >> @ Arrow >> > > >> >> ~/Code/arrow-julia/verification/apache-arrow-julia-2.5.1/src/table.jl:498 >> > > >> [6] iterate(x::Arrow.VectorIterator, ::Tuple{Int64, Int64, >> Int64}) >> > > >> @ Arrow >> > > >> >> ~/Code/arrow-julia/verification/apache-arrow-julia-2.5.1/src/table.jl:474 >> > > >> [7] iterate >> > > >> @ >> > > >> >> ~/Code/arrow-julia/verification/apache-arrow-julia-2.5.1/src/table.jl:471 >> > > >> [inlined] >> > > >> [8] copyto!(dest::Vector{Any}, src::Arrow.VectorIterator) >> > > >> @ Base ./abstractarray.jl:946 >> > > >> [9] _collect >> > > >> @ ./array.jl:713 [inlined] >> > > >> [10] collect >> > > >> @ ./array.jl:707 [inlined] >> > > >> [11] macro expansion >> > > >> @ >> > > >> >> ~/Code/arrow-julia/verification/apache-arrow-julia-2.5.1/src/table.jl:376 >> > > >> [inlined] >> > > >> [12] (::Arrow.var"#108#114"{Bool, Channel{Any}, >> > > >> WorkerUtilities.OrderedSynchronizer, Dict{Int64, >> Arrow.DictEncoding}, >> > > >> Arrow.Batch, Int64})() >> > > >> @ Arrow ./threadingconstructs.jl:341 >> > > >> ``` >> > > >> >> > > >> I haven't gotten a chance to look more into it/try again. >> > > >> >> > > >> [1]: >> https://gist.github.com/lidavidm/b8f604b60c0a2cdfb04e96d4e58bdfdb >> > > >> >> > > >> On Wed, Apr 12, 2023, at 06:50, Sutou Kouhei wrote: >> > > >> > Hi, >> > > >> > >> > > >> > I would like to propose the following release candidate (RC1) of >> > > >> > Apache Arrow Julia version 2.5.1. >> > > >> > >> > > >> > This release candidate is based on commit: >> > > >> > 22088f1cb59bcd99fbffbf9d8248e491690dbfd9 [1] >> > > >> > >> > > >> > The source release rc1 is hosted at [2]. >> > > >> > >> > > >> > Please download, verify checksums and signatures, run the unit >> tests, >> > > >> > and vote on the release. See [3] for how to validate a release >> candidate. >> > > >> > >> > > >> > The vote will be open for at least 24 hours. >> > > >> > >> > > >> > [ ] +1 Release this as Apache Arrow Julia 2.5.1 >> > > >> > [ ] +0 >> > > >> > [ ] -1 Do not release this as Apache Arrow Julia 2.5.1 because... >> > > >> > >> > > >> > [1]: >> > > >> > >> > > >> >> https://github.com/apache/arrow-julia/tree/22088f1cb59bcd99fbffbf9d8248e491690dbfd9 >> > > >> > [2]: >> > > >> > >> > > >> >> https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-julia-2.5.1-rc1/ >> > > >> > [3]: >> > > >> > >> > > >> >> https://github.com/apache/arrow-julia/blob/main/dev/release/README.md#verify >> > > >> >> > > >> > >> >
