Just a note that I wasn't able to produce an error building Arrow C++ using clang-dev [1]. That isn't to say one doesn't still exist (I will test more thoroughly in the coming days), but it does suggest that it's something we can/should handle at the packaging stage if it does pop up (rather than block a release).
[1] https://github.com/apache/arrow/issues/33819 On Sat, Jan 21, 2023 at 8:44 PM Sutou Kouhei <k...@clear-code.com> wrote: > Hi, > > > * Fix now, include in an 11.0.0 RC1, start a new vote. > > * Proceed with RC0, fix for 12.0.0 (and 11.0.1, should it happen), and > > cherry-pick the fix into the bundle we upload to CRAN for 11.0.0. (This > is > > something we do regularly, not a crazy exception.) > > We don't find any blocker for 11.0.0 for now. How about > releasing 11.0.0 with RC0 and releasing 11.0.1 with clang 16 > support? (The latter option.) > > > We may want to add a CI job with llvm-toolchain-snapshot > https://apt.llvm.org/focal/pool/main/l/llvm-toolchain-snapshot/ > . We will be able to avoid this situation (Apache Arrow C++ > doesn't work with unreleased LLVM) with it in future. > > > > Thanks, > -- > kou > > In <caocv4hjj_jzv4fwupdm9dbyjifvgsv0s96p+vwgsf17efmm...@mail.gmail.com> > "Re: [VOTE] Release Apache Arrow 11.0.0 - RC0" on Fri, 20 Jan 2023 > 10:50:29 -0500, > Neal Richardson <neal.p.richard...@gmail.com> wrote: > > > I received an email this morning from the CRAN maintainers about a C++ > > build failure on clang 16. Although clang 16 is not scheduled for release > > until March, CRAN wants to ensure that all packages build successfully on > > it when it becomes available, so they've given us an ultimatum to fix the > > issue or face removal. > > > > Whether or not we agree with this policy (not relevant for us to discuss > > here), we have two options: > > > > * Fix now, include in an 11.0.0 RC1, start a new vote. > > * Proceed with RC0, fix for 12.0.0 (and 11.0.1, should it happen), and > > cherry-pick the fix into the bundle we upload to CRAN for 11.0.0. (This > is > > something we do regularly, not a crazy exception.) > > > > https://www.stats.ox.ac.uk/pub/bdr/clang16/README.txt suggests that the > fix > > could be as easy as upgrading our bundled boost version, but we won't > know > > for sure until we reproduce it. We suppress libarrow build output on > CRAN, > > so unfortunately there are no logs from their report. > > > > I'm fine with either option. clang 16 will be out before we do the 12.0.0 > > release, and it would be nice if we compiled successfully on it, but I > > don't have strong feelings as to whether that is "nice to have" enough to > > force an RC1. > > > > Neal > > > > On Fri, Jan 20, 2023 at 8:39 AM Raúl Cumplido <raulcumpl...@gmail.com> > > wrote: > > > >> +1 (non binding) > >> > >> I have tested both SOURCES and BINARIES successfully with: > >> TEST_DEFAULT=0 TEST_SOURCE=1 dev/release/verify-release-candidate.sh > 11.0.0 > >> 0 > >> TEST_DEFAULT=0 TEST_WHEELS=1 dev/release/verify-release-candidate.sh > 11.0.0 > >> 0 > >> TEST_DEFAULT=0 TEST_BINARIES=1 dev/release/verify-release-candidate.sh > >> 11.0.0 0 > >> with: > >> * Python 3.10.6 > >> * gcc (Ubuntu 11.3.0-1ubuntu1~22.04) 11.3.0 > >> * NVIDIA CUDA cuda_11.5.r11.5/compiler.30672275_0 > >> * openjdk 17.0.5 2022-10-18 > >> * ruby 3.0.2p107 (2021-07-07 revision 0db68f0233) [x86_64-linux-gnu] > >> * dotnet 6.0.202 > >> * Ubuntu 22.04 LTS > >> > >> From my understanding the identified issues are not release blockers, > >> that's why I am voting +1: > >> [1] https://github.com/apache/arrow/issues/33783 > >> We are compatible with dotnet 7.0.x but we are only compatible testing > with > >> 6.0.x. More info on the issue and PR associated. > >> [2] https://github.com/apache/arrow/issues/33786 > >> XSIMD on Ubuntu, I have tested the proposed workaround and built and run > >> verification successfully. > >> [3] https://github.com/apache/arrow/issues/15054 > >> aws-sdk-cpp leak and flaky test crash. More discussions on the issue but > >> doesn't seem to be a blocker. > >> > >> Thanks, > >> Raúl > >> > >> El vie, 20 ene 2023 a las 6:06, Weston Pace (<weston.p...@gmail.com>) > >> escribió: > >> > >> > I've got a fix[1] in for the verification script for C#. There are > >> > more details in the issue and the PR but IMO we are compatible with > >> > C#7 and C#6, we simply were not testing it correctly. I have run the > >> > tests locally with both 6.0 and 7.0 sdks and they passed. > >> > > >> > [1] https://github.com/apache/arrow/pull/33799 > >> > > >> > On Thu, Jan 19, 2023 at 5:52 PM Jacob Wujciak > >> > <ja...@voltrondata.com.invalid> wrote: > >> > > > >> > > I have investigated the issue of the system xsimd causing an error > [1] > >> > and > >> > > I don't think this should be a blocker as it can be circumvented by > >> > > explicitly setting xsimd_SOURCE=BUNDLED. > >> > > I don't think the incompatibility with C# 7 should be a blocker > either, > >> > it > >> > > should probably be documented that we are not compatible with that > >> > version > >> > > somewhere (if that is not already the case) but otherwise it is > fine, > >> > e.g. > >> > > JS is incompatible with nodejs 18. > >> > > > >> > > [1]: https://github.com/apache/arrow/issues/33786 > >> > > > >> > > On Thu, Jan 19, 2023 at 6:08 PM Rok Mihevc <rok.mih...@gmail.com> > >> wrote: > >> > > > >> > > > On a relatively fresh Ubuntu 22.04 without conda I had to apt > install > >> > some > >> > > > libs (default-jdk > >> > > > maven libjemalloc-dev libgirepository1.0-dev libsqlite3-dev) and > this > >> > > > passed fine: > >> > > > TEST_DEFAULT=0 TEST_SOURCE=1 > dev/release/verify-release-candidate.sh > >> > > > > >> > > > +1 > >> > > > > >> > > > Rok > >> > > > > >> > > > On Thu, Jan 19, 2023 at 3:05 PM Raúl Cumplido < > >> raulcumpl...@gmail.com> > >> > > > wrote: > >> > > > > >> > > > > Thanks Antoine, I can finally reproduce it. > >> > > > > > >> > > > > Thanks Jacob Wujciak for the pointer on the log, I couldn't find > >> it: > >> > > > > > >> > > > > -- Building xsimd from source > >> > > > > CMake Error at cmake_modules/ThirdpartyToolchain.cmake:2295 > >> > > > (add_library): > >> > > > > add_library cannot create imported target "xsimd" because > another > >> > > > target > >> > > > > with the same name already exists. > >> > > > > Call Stack (most recent call first): > >> > > > > CMakeLists.txt:498 (include) > >> > > > > > >> > > > > I can reproduce it if I install `apt install libxsimd-dev`. > >> > > > > > >> > > > > I've opened an issue to track it here: > >> > > > > https://github.com/apache/arrow/issues/33786 > >> > > > > > >> > > > > Thanks! > >> > > > > > >> > > > > El jue, 19 ene 2023 a las 13:27, Antoine Pitrou (< > >> anto...@python.org > >> > >) > >> > > > > escribió: > >> > > > > > >> > > > > > > >> > > > > > I used the following command: > >> > > > > > > >> > > > > > LANG=C TEST_DEFAULT=0 TEST_CPP=1 > >> > > > > > ./dev/release/verify-release-candidate.sh 11.0.0 0 > >> > > > > > > >> > > > > > Here is the full output: > >> > > > > > > >> > > > > > > https://gist.github.com/pitrou/3fdca2460fa71bba731b0706703b70b2 > >> > > > > > > >> > > > > > Regards > >> > > > > > > >> > > > > > Antoine. > >> > > > > > > >> > > > > > > >> > > > > > Le 19/01/2023 à 13:07, Raúl Cumplido a écrit : > >> > > > > > > El jue, 19 ene 2023 a las 12:21, Antoine Pitrou (< > >> > anto...@python.org > >> > > > >) > >> > > > > > > escribió: > >> > > > > > > > >> > > > > > >> > >> > > > > > >> On Ubuntu 22.04, C++ source verification *without conda* > fails > >> > > > because > >> > > > > > >> it is attempting to find various libraries (re2, LLVM, > >> > rapidjson, > >> > > > > etc.). > >> > > > > > >> > >> > > > > > >> Antoine, could you help me understand what the issue is > here > >> or > >> > how > >> > > > to > >> > > > > > > reproduce it? I can't reproduce it. > >> > > > > > > > >> > > > > > > I don't use conda, I use Ubuntu 22.04 and apart from being > able > >> > to > >> > > > > > > reproduce the C# issue if I use .NET 7.0.102 the rest looks > >> good > >> > on > >> > > > my > >> > > > > > side > >> > > > > > > (when using old C#): > >> > > > > > > > >> > > > > > > $ TEST_DEFAULT=0 TEST_SOURCE=1 > >> > > > dev/release/verify-release-candidate.sh > >> > > > > > > 11.0.0 0 > >> > > > > > > ... > >> > > > > > > Release candidate 11.0.0-RC0 looks good! > >> > > > > > > > >> > > > > > > > >> > > > > > >> C++ source verification succeeds with conda. > >> > > > > > >> > >> > > > > > >> > >> > > > > > >> > >> > > > > > >> Le 19/01/2023 à 11:06, Raúl Cumplido a écrit : > >> > > > > > >>> Hi, > >> > > > > > >>> > >> > > > > > >>> I would like to propose the following release candidate > (RC0) > >> > of > >> > > > > Apache > >> > > > > > >>> Arrow version 11.0.0. This is a release consisting of 423 > >> > > > > > >>> resolved GitHub issues[1]. > >> > > > > > >>> > >> > > > > > >>> This release candidate is based on commit: > >> > > > > > >>> f10f5cfd1376fb0e602334588b3f3624d41dee7d [2] > >> > > > > > >>> > >> > > > > > >>> The source release rc0 is hosted at [3]. > >> > > > > > >>> The binary artifacts are hosted at > >> [4][5][6][7][8][9][10][11]. > >> > > > > > >>> The changelog is located at [12]. > >> > > > > > >>> > >> > > > > > >>> Please download, verify checksums and signatures, run the > >> unit > >> > > > tests, > >> > > > > > >>> and vote on the release. See [13] for how to validate a > >> release > >> > > > > > >> candidate. > >> > > > > > >>> > >> > > > > > >>> See also a verification result on GitHub pull request > [14]. > >> > > > > > >>> > >> > > > > > >>> The vote will be open for at least 72 hours. > >> > > > > > >>> > >> > > > > > >>> [ ] +1 Release this as Apache Arrow 11.0.0 > >> > > > > > >>> [ ] +0 > >> > > > > > >>> [ ] -1 Do not release this as Apache Arrow 11.0.0 > because... > >> > > > > > >>> > >> > > > > > >>> [1]: https://github.com/apache/arrow/milestone/1?closed=1 > >> > > > > > >>> [2]: > >> > > > > > >>> > >> > > > > > >> > >> > > > > > > >> > > > > > >> > > > > >> > > >> > https://github.com/apache/arrow/tree/f10f5cfd1376fb0e602334588b3f3624d41dee7d > >> > > > > > >>> [3]: > >> > > > > > >> > >> > > > > https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-11.0.0-rc0 > >> > > > > > >>> [4]: > https://apache.jfrog.io/artifactory/arrow/almalinux-rc/ > >> > > > > > >>> [5]: > >> > https://apache.jfrog.io/artifactory/arrow/amazon-linux-rc/ > >> > > > > > >>> [6]: https://apache.jfrog.io/artifactory/arrow/centos-rc/ > >> > > > > > >>> [7]: https://apache.jfrog.io/artifactory/arrow/debian-rc/ > >> > > > > > >>> [8]: > >> > https://apache.jfrog.io/artifactory/arrow/java-rc/11.0.0-rc0 > >> > > > > > >>> [9]: > >> > https://apache.jfrog.io/artifactory/arrow/nuget-rc/11.0.0-rc0 > >> > > > > > >>> [10]: > >> > > > https://apache.jfrog.io/artifactory/arrow/python-rc/11.0.0-rc0 > >> > > > > > >>> [11]: > https://apache.jfrog.io/artifactory/arrow/ubuntu-rc/ > >> > > > > > >>> [12]: > >> > > > > > >>> > >> > > > > > >> > >> > > > > > > >> > > > > > >> > > > > >> > > >> > https://github.com/apache/arrow/blob/f10f5cfd1376fb0e602334588b3f3624d41dee7d/CHANGELOG.md > >> > > > > > >>> [13]: > >> > > > > > >>> > >> > > > > > >> > >> > > > > > > >> > > > > > >> > > > > >> > > >> > https://cwiki.apache.org/confluence/display/ARROW/How+to+Verify+Release+Candidates > >> > > > > > >>> [14]: https://github.com/apache/arrow/pull/33751 > >> > > > > > >>> > >> > > > > > >> > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > >> >
