+1 (binding) Thank you for this effort -- I think having a more full featured standard SQL interface is valuable
re integration testing there is an integration test (example [1]) that checks Arrow Flight and IPC interoperability; Perhaps we could extend the same framework to cover FlightSQL. I don't have an opinion on if the integration test should be mandatory Andrew [1] https://github.com/apache/arrow/runs/4460258054?check_suite_focus=true On Wed, Dec 8, 2021 at 8:28 AM Kyle Porter <ky...@bitquilltech.com.invalid> wrote: > The team initially developed the C++ client against the Java server, and > have done some cross language testing. It wasn't exhaustive or methodical > in nature, however. Is cross language testing something that's usually > done? > > On Wed., Dec. 8, 2021, 9:18 a.m. David Li, <lidav...@apache.org> wrote: > > > There is not an integration test. Do we want to require this? > > > > Also CC @Kyle, in case your team has done such testing. > > > > It looks like Flight itself did not have a test for a few versions after > > it was initially implemented. > > > > -David > > > > On Tue, Dec 7, 2021, at 23:19, Micah Kornfield wrote: > > > Is there an integration test between the two languages? > > > > > > On Tue, Dec 7, 2021 at 1:35 PM David Li <lidav...@apache.org> wrote: > > > > > > > Hello, > > > > > > > > Kyle Porter, Rafael Telles, Ryan Nicholson, et. al. have proposed > > adding > > > > Arrow Flight SQL, an experimental protocol for interacting with SQL > > > > databases over Arrow Flight [1], as explained in a previous ML > > discussion > > > > [2] and in a design document [3]. The purpose of Flight SQL is to > allow > > > > clients and SQL database servers to communicate (execute queries, > list > > > > tables, create prepared statements, etc.) using Arrow and Arrow > > Flight, by > > > > defining how to use Flight RPC methods, as well as message payloads > to > > use > > > > with those methods. > > > > > > > > The new protocol definitions can be found at [4]. > > > > > > > > They have provided pull requests implementing the server and client > > > > protocol in C++ [5] and Java [6] which can be merged after this > > addition is > > > > approved. > > > > > > > > Please vote whether to accept this addition. The vote will be open > for > > at > > > > least 72 hours. > > > > > > > > [1]: https://arrow.apache.org/docs/format/Flight.html > > > > [2]: > https://lists.apache.org/thread/s08b20ty756qq10zybd9qr0mm4jhmz93 > > > > [3]: > > > > > > > https://docs.google.com/document/d/1WQz32bDF06GgMdEYyzhakqUigBZkALFwDF2y1x3DTAI/edit?usp=sharing > > > > Note that the protocol definitions in the design document are out of > > date; > > > > the canonical reference is in the pull requests. > > > > [4]: > > > > > > > https://github.com/apache/arrow/blob/72ce72ba855909052f7dfb898105b419697157c8/format/FlightSql.proto > > > > [5]: https://github.com/apache/arrow/pull/11507 > > > > [6]: https://github.com/apache/arrow/pull/10906 > > > > > > > > Thanks, > > > > David > > > > > >
