As a beginner contributor I believe I can vote for linting as part of the build.
For me the best would be BEGINNER/ALL_CHECKS option in the Makefile that does all the linting and all checks done in the build. And in the instruction it would be clearly suggested to use it. BR, Jacek śr., 19 lut 2020 o 20:40 Antoine Pitrou <[email protected]> napisał(a): > > > Hi, > > On Wed, 19 Feb 2020 09:59:04 -0800 > > > > It doesn't have to be this way. With GitHub Actions, we can run workflows > > that fix style and other violations and push the fix in a commit back to > > the branch. > > I'm rather opposed to this. Doing automated pushes behind the user's > back will feel confusing and slightly obnoxious. > > > Style guides and linting are important for large projects like Arrow, but > > we don't want to add unnecessary friction to the dev process, particularly > > for new contributors--it's challenging enough without it. > > Well, at worse, we can push fixes ourselves before merging a PR if the > only remaining ones are style fixes. > > > What are your thoughts? If anyone objects to using GitHub Actions in this > > way, would you be satisfied with blacklisting your fork (i.e. you don't > > want it running on your branches but you don't mind if others do)? > > Egoistically, that would satify me, but I'm not sure it would be less > confusing to beginner contributors. > > Regards > > Antoine. > >
