It might pay to open up a separate thread on the Java specifically. I think automatic formatting might have been discussed before but people were afraid of the magnitude of the change.
I'm also slightly against automated pushes, having something in Ursabot or GHA which could be easily invoked would could add value though. Cheers, Micah On Wed, Feb 19, 2020 at 2:29 PM Andy Grove <[email protected]> wrote: > To backtrack slightly on my earlier email, when I said "I couldn't agree > more" I was speaking to the frustrations around builds failing due to > linting errors and then having to manually fix them. > > I think if we make as easy as possible for committers to automate the > formatting before pushing (and document this in the README for each > implementation) then it would be very helpful. Using Github actions to push > is likely to cause merge conflicts which can be difficult to deal with. > > Thanks, > > Andy. > > On Wed, Feb 19, 2020 at 12:40 PM Antoine Pitrou <[email protected]> > wrote: > > > > > Hi, > > > > On Wed, 19 Feb 2020 09:59:04 -0800 > > > > > > It doesn't have to be this way. With GitHub Actions, we can run > workflows > > > that fix style and other violations and push the fix in a commit back > to > > > the branch. > > > > I'm rather opposed to this. Doing automated pushes behind the user's > > back will feel confusing and slightly obnoxious. > > > > > Style guides and linting are important for large projects like Arrow, > but > > > we don't want to add unnecessary friction to the dev process, > > particularly > > > for new contributors--it's challenging enough without it. > > > > Well, at worse, we can push fixes ourselves before merging a PR if the > > only remaining ones are style fixes. > > > > > What are your thoughts? If anyone objects to using GitHub Actions in > this > > > way, would you be satisfied with blacklisting your fork (i.e. you don't > > > want it running on your branches but you don't mind if others do)? > > > > Egoistically, that would satify me, but I'm not sure it would be less > > confusing to beginner contributors. > > > > Regards > > > > Antoine. > > > > > > >
