Maybe a utility method to get a date instead of a datetime at least would be useful? And/or documentation of the fact that the default behavior is semantically incorrect, and what it does (return a datetime at midnight for the date).
Best, David On Tue, Sep 17, 2019, 04:08 Fan Liya <liya.fa...@gmail.com> wrote: > I think there are similar problems with other time related vectors. > > Best, > Liya Fan > > > On Tue, Sep 17, 2019 at 1:02 PM Micah Kornfield <emkornfi...@gmail.com> > wrote: > > > Anyone have an opinion on this? Personally, I'm leaning on keeping the > > existing API compatibility, but I don't feel too strongly about it. > > > > On Mon, Sep 9, 2019 at 7:39 PM Micah Kornfield <emkornfi...@gmail.com> > > wrote: > > > > > Yongbo Zhang, > > > Opened up a pull request to have DateMilliVector return a LocalDate > > > instead of a LocalDateTime object. > > > > > > Do people have opinions if this breaking change is worth the > correctness? > > > > > > Thanks, > > > Micah > > > > > > [1] https://github.com/apache/arrow/pull/5315 > > > > > > On Sat, Sep 7, 2019 at 4:14 PM Yongbo Zhang <zhangyongbo0...@gmail.com > > > > > wrote: > > > > > >> Summary: [Java] DateMilliVector.getObject() should return a LocalDate, > > >> not a LocalDateTime > > >> Key: ARROW-1984 > > >> URL: https://issues.apache.org/jira/browse/ARROW-1984 > > >> Pull Request: https://github.com/apache/arrow/pull/5315 > > >> Project: Apache Arrow > > >> Issue Type: Bug > > >> Components: Java > > >> Reporter: Vanco Buca > > >> Assignee: Yongbo Zhang > > >> Fix For: 0.15.0 > > >> > > >> This is an API breaking change therefore we may want to discuss about > it > > >> before merging any PRs in. > > >> > > > > > >
