Hey Antoine,

On Thu, Sep 5, 2019 at 2:54 PM Antoine Pitrou <anto...@python.org> wrote:

>
> Le 05/09/2019 à 14:43, Uwe L. Korn a écrit :
> > Hello Krisztián,
> >
> >> Am 05.09.2019 um 14:22 schrieb Krisztián Szűcs <
> szucs.kriszt...@gmail.com>:
> >>
> >>> * The build configuration is automatically updated on a merge to
> master?
> >>>
> >> Not yet, but this can be automatized too with buildbot itself.
> >
> > This is something I would  actually like to have before getting rid of
> the Travis jobs. Otherwise we would be constrainted quite a bit in
> development when master CI breaks because of an environment issue until one
> of the few people who can update the config become available.
>
> I would go further and say that PRs and branches need to be able to run
> different build configurations.  We are moving too fast to afford an
> inflexible centralized configuration.
>
Agree. I haven't had time to work on it yet, although I have a couple of
solutions in mind. Once we decide to move on with this proposal we
can allocate time to resolve it.

>
> If going with buildbot, this means that the various build steps need to
> be generic like in Travis-CI (e.g. "install", "setup", "before-test",
> "test", "after-test"...) and their contents expressed outside of the
> buildmaster configuration per se.
>
This is partially resolved with the Builder abstraction, see an example
here [1]. We just need to add and reload these Builder configurations
dynamically on certain events, like when someone changes a builder
from a PR.

[1]:
https://github.com/apache/arrow/blob/305e7387d429f095019c74f17e0c9c7cb443bb70/ci/buildbot/arrow/builders.py#L366


>
> Regards
>
> Antoine.
>

Reply via email to