imho, list just show what a service has. does not need to provide detail information about each one. we already have a separate method to fetch detail about a flight. optionally we could change GetFlightInfo(FlightDescriptor) returns (FlightGetInfo) {} to input a stream so someone could fetch a batch of info.
also is it possible a service have tons of flights? if so, some kind of pagination need to be done here? ming On Wed, Apr 3, 2019 at 11:41 AM Wes McKinney <wesmck...@gmail.com> wrote: > hi Jacques, > > I agree with you -- I had this concern also during implementation that > the query plans have to be generated both in ListFlights and > GetFlightInfo. > > Antoine -- I think "splits" here means the pieces of a distributed > dataset. So if a Flight is spread across multiple hosts, then when you > call ListFlights currently the server has to compute for each flight > the endpoints and location(s) for each piece. > > - Wes > > On Wed, Apr 3, 2019 at 10:05 AM Antoine Pitrou <solip...@pitrou.net> > wrote: > > > > On Wed, 3 Apr 2019 08:01:25 -0700 > > Jacques Nadeau <jacq...@apache.org> wrote: > > > Right now, the ListFlights method returns a stream of FlightGetInfo > (to be > > > renamed FlightInfo). This actually turns out to be quite expensive in > many > > > cases since splits have to be generated. I'd like to propose changing > this > > > method to return a stream of FlightDescriptors instead. What do people > > > think? > > > > > > rpc ListFlights(Criteria) returns (stream FlightGetInfo) {} > > > > > > to > > > > > > rpc ListFlights(Criteria) returns (stream FlightDescriptor) {} > > > > Can you explain what you call "splits"? > > > > Regards > > > > Antoine. > > > > >