+1 from me too
On 3 May 2013, at 09:37, Jean-Louis Boudart <jeanlouis.boud...@gmail.com> wrote:
> +1
>
>
> 2013/5/3 Antoine Levy Lambert <anto...@gmx.de>
>
>> I wonder whether we could not add if an unless on all nested elements in
>> the framework ?
>>
>>
>> Regards,
>>
>> Antoine
>> On May 3, 2013, at 2:57 AM, Jean-Louis Boudart wrote:
>>
>>> Hi,
>>>
>>> It's currently difficult to make reusable script when using <exec> task
>> or
>>> any other task using commandline args.
>>> We oftenly need some "dynamic arguments" and this can be complicated.
>>>
>>> Therefor, i suggest to introduce if/unless conditions on comand line
>> args :
>>>
>>> <exec executable="git">
>>> <arg value="commit"/>
>>> <arg line="-a" if="${commit.all.files}"/>
>>> <arg value="-m"/>
>>> <arg value="${commit.message}"/>
>>> </exec>
>>>
>>> I have a working implementation with related tests and documentation.
>>> Commandline.Arg class now extends ProjectComponent, and expose accessors
>>> for if/unless condition, and rely on PropertyHelper to check conditions.
>>>
>>> Is this sufficient ? From what i have seen, it doesn't break backward
>>> compatibility at least all tests are green :p.
>>>
>>> The setProject(Project p) method should be invoked "automatically" by
>>> ProjectHelper isn't it ?
>>>
>>> If ant is used in pure java and we ommited invoking setProject(Project p)
>>> method, it should also works as PropertyHelper seems null safe.
>>>
>>> If there is no objection i will commit this this week end.
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
>> For additional commands, e-mail: dev-h...@ant.apache.org
>>
>>
>
>
> --
> Jean Louis Boudart
> Independent consultant
> Apache EasyAnt commiter http://ant.apache.org/easyant/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
