On Tue, 15 Jul 2003, Jeff Tulley <[EMAIL PROTECTED]> wrote: > Shouldn't the last if statement instead be the following?: > > if (!path.startsWith(File.separator)) { > sb.append("/"); > }
Yes, I think so. > I would also add some tests to FileUtilsTest.java Thanks a lot. > in fromURI, I think it is sufficient to look for a ":" anywhere in > the filename, instead of just at the second position. Sounds OK as File.pathSeparatorChar == ';' should exclude any filesystem that would allow filenames with embeded colons, or so it seems. > Hopefully my attachments are in a format that won't be stripped by > the mailing list, I can never remember what extension they need. 8-) .txt seems to be fine. AFAIK we only strip HTML (and I'd expect the Content-Type header to be consulted, not the filename extension). I'll take care of the patches. Stefan --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]