Connor, It looks like indeed this will change the behavior a little bit, though if it has any adverse effect remains to be seen. Previously NetWare would have been completely excluded from that if statement, but since NetWare's pathSeparatorChar is indeed ";", this block could conceivably run on NetWare now.
Looking at it, the fromURI is a method I should have considered and added some NetWare test cases for. I'll work out some test cases, see if the previous code handled them and suggest changes if necessary. There is a good chance that I should've made NetWare specific changes to this in the old code. The biggest difference on NetWare is that it can have drive names that look like windows, except they are more than on character. "sys:" is the most common, though they can be anything (up to 40 chars, I think). So, code that only looks into the second character position for a ":" is usually insufficient. Jeff Tulley ([EMAIL PROTECTED]) (801)861-5322 Novell, Inc., The Leading Provider of Net Business Solutions http://www.novell.com >>> [EMAIL PROTECTED] 7/8/03 6:11:50 AM >>> On Thu, 3 Jul 2003 11:16 pm, Stefan Bodewig wrote: > > It's JDK 1.1 legacy as far as I'm concerned and could those be swapped > against the commented Axis' code. > It turns out this "legacy" code works better than the commented out code because it handles spaces in file names (which are otherwise rendered as %20) So, I can move the code into Locator but I also need to move FileUtils.fromURI() which is not too much of a problem, except for its use of Os.isFamily("dos") and FileUtils.normalize(). The first, I intend to replace with (File.pathSeparatorChar == ';'). That should be equivalent except on Netware but I'm not sure if Netware should be excluded or not - i.e. is the original code based on "dos" correct? The second linkage, the normalize call, I will just remove. So overall actions are 1. Move getClassSource and getResourceSource to Locator from LoaderUtils. 2. Move bulk of fromURI from FileUtils to Locator.fromURI 3. Recode FileUtils.fromURI to use Locator.fromURI with the additional normalize step Since all the methods are 1.6 methods there are no backward compat issues. The issues could be 1. getClassSource and getReosurceSource results will not be normalized. I don't think that is a great issue 2. Netware operation? Thoughts Conor --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
