+1 (binding) - checked reproducibility, licences, signatures, checksum and tested my changes
On Tue, 10 Jun 2025 at 03:49, Wei Lee <weilee...@gmail.com> wrote: > +1 non-binding, tested my changes and a few dags > > Best, > Wei > > > On Jun 10, 2025, at 3:27 AM, Rahul Vats <rah.sharm...@gmail.com> wrote: > > > > +1 non binding. Tried running example dags all looks good. > > > > Regards, > > Rahul Vats > > > > > > On Mon, 9 Jun, 2025, 11:52 Amogh Desai, <amoghdesai....@gmail.com> > wrote: > > > >> @Jarek Potiuk <ja...@potiuk.com> I agree with you. We should have a > >> separate doc for task sdk related verification and testing > >> sometime. Not urgent, but we can try to get that in by next release. > >> > >> Thanks & Regards, > >> Amogh Desai > >> > >> > >> On Mon, Jun 9, 2025 at 11:49 AM Amogh Desai <amoghdesai....@gmail.com> > >> wrote: > >> > >>> +1 non binding. > >>> > >>> Long list of changes, installed the RC and tested for a few things > along > >>> with couple of my testing dags. > >>> > >>> CI: > >>> https://github.com/apache/airflow/pull/50291 > >>> https://github.com/apache/airflow/pull/50721 > >>> https://github.com/apache/airflow/pull/50731 > >>> https://github.com/apache/airflow/pull/50974 > >>> https://github.com/apache/airflow/pull/50996 > >>> https://github.com/apache/airflow/pull/51126 > >>> https://github.com/apache/airflow/pull/51342 > >>> > >>> Actual changes: > >>> https://github.com/apache/airflow/pull/50384 -- works as expected > >>> https://github.com/apache/airflow/pull/50596 -- works as expected > >>> https://github.com/apache/airflow/pull/50602 -- works as expected > >>> https://github.com/apache/airflow/pull/50697 -- works as expected > >>> https://github.com/apache/airflow/pull/50808 -- works fine > >>> https://github.com/apache/airflow/pull/50809 -- ui renders fine > >>> https://github.com/apache/airflow/pull/50889 -- works fine > >>> https://github.com/apache/airflow/pull/50927 -- works fine > >>> https://github.com/apache/airflow/pull/50953 -- works fine > >>> https://github.com/apache/airflow/pull/50998 -- works fine > >>> https://github.com/apache/airflow/pull/51008 -- back compat restored > >>> https://github.com/apache/airflow/pull/51291 -- works fine > >>> > >>> Doc changes: > >>> https://github.com/apache/airflow/pull/49987 > >>> https://github.com/apache/airflow/pull/50293 > >>> https://github.com/apache/airflow/pull/50819 > >>> https://github.com/apache/airflow/pull/50954 > >>> https://github.com/apache/airflow/pull/50967 > >>> https://github.com/apache/airflow/pull/51186 > >>> > >>> > >>> Thanks & Regards, > >>> Amogh Desai > >>> > >>> > >>> On Sun, Jun 8, 2025 at 4:37 AM Jarek Potiuk <ja...@potiuk.com> wrote: > >>> > >>>> +1 (binding) > >>>> > >>>> Checked my changes, reproducibility, signatures, checksums, I ran it > >>>> locally. All looks good. The important "user facing" part I was quite > >>>> involved in and added temporary solution to - example dags moved to > >>>> standard provider are good - even if they are technically in standard > >>>> provider, they are still visible when you specify "load_example_dags" > >>>> and you can use all the "standard" DAGs for testing. > >>>> > >>>> I worked with Jens and the main `breeeze` has already an improved > >>>> version of breeze that will install pre-release providers if needed > >>>> (so the problem signalled by Jens above, the problem was that `breeze > >>>> --use-airflow-version 3.0.2rc2` did not use --pre to install > >>>> pre-release version of `fab` - this is now fixed, so if anyone wants > >>>> to use `breeze start-airflow` - it will nicely load pre-release > >>>> version of `fab-2.2.0` that has the right pre-release limits. So the > >>>> error indicated above was really a breeze command installation missing > >>>> feature. Right now the `--pre` flag will be used automatically when > >>>> you install a pre-release version of Airflow, you can also add > >>>> `--allow-pre-releases` flag to install pre-release providers, > >>>> task-sdk, airflowctll with any version of airflow you put in > >>>> `--use-airflow-version' (including installing from local wheels and > >>>> remote github URL links). > >>>> > >>>> One thing that might be something to improve - currently we have no > >>>> release checks for `task-sdk` - so it would be great to have a. > >>>> separate docs for verification and testing of it - unlike for other > >>>> components - even some of the current testing commands are failing and > >>>> you need to manually modify them to accommodate. Not a big deal, but > >>>> might be good to add dev/README_RELEASE_TASK_SDK.md soon. > >>>> > >>>> J. > >>>> > >>>> > >>>> > >>>> > >>>> J. > >>>> > >>>> > >>>> > >>>> > >>>> On Sat, Jun 7, 2025 at 7:30 PM Jens Scheffler > >>>> <j_scheff...@gmx.de.invalid> wrote: > >>>>> > >>>>> +1 (binding) - Checked SVN, Reproducible package build, Licenses, > >>>> Signatures > >>>>> > >>>>> I attempted to test locally via breeze and generated a strange error > >>>>> when attempting to use EdgeExecutor. Dropped a discussion in > >>>>> > >> https://apache-airflow.slack.com/archives/C03G9H97MM2/p1749315982085709 > >>>>> to qualify if this is a blocking problem. > >>>>> > >>>>> Otherwise did some basic integration tests with LocalExecutor and for > >>>>> all seems to be good otherwise. > >>>>> > >>>>> On 06.06.25 12:08, Kaxil Naik wrote: > >>>>>> Hey fellow Airflowers, > >>>>>> > >>>>>> The release candidates for *Apache Airflow 3.0.2rc2* and *Task SDK > >>>>>> 1.0.2rc2* are > >>>>>> now available for testing! > >>>>>> > >>>>>> This email is calling for a vote on the release, which will last at > >>>> least > >>>>>> until *10th June* and until 3 binding +1 votes have been received. > >>>>>> > >>>>>> Consider this my +1 binding vote. > >>>>>> > >>>>>> Airflow 3.0.2rc2 is available at: > >>>>>> https://dist.apache.org/repos/dist/dev/airflow/3.0.2rc2/ > >>>>>> > >>>>>> "apache-airflow" Meta package: > >>>>>> > >>>>>> > >>>>>> - *apache-airflow-3.0.2-source.tar.gz* is a source release that > >>>> comes > >>>>>> with INSTALL instructions. > >>>>>> - *apache-airflow-3.0.2.tar.gz* is the binary Python "sdist" > >>>> release. > >>>>>> - *apache_airflow-3.0.2-py3-none-any.whl* is the binary Python > >>>>>> wheel "binary" release. > >>>>>> > >>>>>> "apache-airflow-core" package > >>>>>> > >>>>>> > >>>>>> - *apache_airflow_core-3.0.2.tar.gz* is the binary Python > >> "sdist" > >>>>>> release. > >>>>>> - *apache_airflow_3.0.2-py3-none-any.whl* is the binary Python > >>>>>> wheel "binary" release. > >>>>>> > >>>>>> Task SDK 1.0.2rc2 is available at: > >>>>>> https://dist.apache.org/repos/dist/dev/airflow/task-sdk/1.0.2rc2/ > >>>>>> > >>>>>> "apache-airflow-task-sdk" package > >>>>>> > >>>>>> - *apache_airflow_task_sdk-1.0.2.tar.gz* is the binary Python > >>>> "sdist" > >>>>>> release. > >>>>>> - *apache_airflow_task_sdk-1.0.2-py3-none-any.whl* is the binary > >>>> Python > >>>>>> wheel "binary" release. > >>>>>> > >>>>>> > >>>>>> Public keys are available at: > >>>>>> https://dist.apache.org/repos/dist/release/airflow/KEYS > >>>>>> > >>>>>> Please vote accordingly: > >>>>>> > >>>>>> [ ] +1 approve > >>>>>> [ ] +0 no opinion > >>>>>> [ ] -1 disapprove with the reason > >>>>>> > >>>>>> Only votes from PMC members are binding, but all members of the > >>>> community > >>>>>> are encouraged to test the release and vote with "(non-binding)". > >>>>>> > >>>>>> The test procedure for PMC members is described in: > >>>>>> > >>>> > >> > https://github.com/apache/airflow/blob/main/dev/README_RELEASE_AIRFLOW.md\#verify-the-release-candidate-by-pmc-members > >>>>>> > >>>>>> The test procedure for contributors and members of the community who > >>>> would > >>>>>> like to test this RC is described in: > >>>>>> > >>>> > >> > https://github.com/apache/airflow/blob/main/dev/README_RELEASE_AIRFLOW.md\#verify-the-release-candidate-by-contributors > >>>>>> > >>>>>> Please note that the version number excludes the 'rcX' string, so > >>>> it's now > >>>>>> simply 3.0.2 for Airflow package and 1.0.2 for Task SDK. This will > >>>> allow us > >>>>>> to rename the artifact without modifying > >>>>>> the artifact checksums when we actually release. > >>>>>> > >>>>>> > >>>>>> *Changes from 3.0.2rc1*: > >>>>>> > >>>>>> - Remove logical_date check when validating inlets and outlets > >>>> (#51464) > >>>>>> - Guard ti update state and set task to fail if exception > >> encountered > >>>>>> (#51295) > >>>>>> > >>>>>> > >>>>>> *Docs* (for preview): > >>>>>> https://airflow.staged.apache.org/docs/apache-airflow/3.0.2 > >>>>>> *Release Notes*: > >>>>>> - > >>>>>> > >>>> > >> > https://github.com/apache/airflow/blob/3.0.2rc2/RELEASE_NOTES.rst#airflow-3-0-2-2025-06-10 > >>>>>> - > >>>>>> > >>>> > >> > https://airflow.staged.apache.org/docs/apache-airflow/3.0.2/release_notes.html > >>>>>> (Rendered HTML) > >>>>>> > >>>>>> > >>>>>> *Testing Instructions using PyPI*: > >>>>>> > >>>>>> You can build a virtualenv that installs this and other required > >>>> packages > >>>>>> (e.g. task sdk), like this: > >>>>>> > >>>>>> ``` > >>>>>> > >>>>>> uv venv > >>>>>> > >>>>>> uv pip install -U apache-airflow==3.0.2rc2 --pre > >>>>>> > >>>>>> ``` > >>>>>> > >>>>>> > >>>>>> Constraints files are at > >>>>>> https://github.com/apache/airflow/tree/constraints-3.0.2rc2 > >>>>>> > >>>>>> Regards, > >>>>>> Kaxil > >>>>>> > >>>>> > >>>>> --------------------------------------------------------------------- > >>>>> To unsubscribe, e-mail: dev-unsubscr...@airflow.apache.org > >>>>> For additional commands, e-mail: dev-h...@airflow.apache.org > >>>>> > >>>> > >>>> --------------------------------------------------------------------- > >>>> To unsubscribe, e-mail: dev-unsubscr...@airflow.apache.org > >>>> For additional commands, e-mail: dev-h...@airflow.apache.org > >>>> > >>>> > >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@airflow.apache.org > For additional commands, e-mail: dev-h...@airflow.apache.org > >
