On Fri, Jul 5, 2019 at 1:28 PM Nathan Froyd <nfr...@mozilla.com> wrote: > > On Fri, Jul 5, 2019 at 2:48 AM Jeff Gilbert <jgilb...@mozilla.com> wrote: > > It is, however, super poignant to me that uint32_t-indexing-on-x64 is > > pessimal, as that's precisely what our ns* containers (nsTArray) use > > for size, /unlike/ their std::vector counterparts, which will be using > > the more-optimal size_t. > > nsTArray uses size_t for indexing since bug 1004098.
We should probably endorse the use of size_t more explicitly in our guidelines. Apart from the issue of object size motivating especially strings using uint32_t for _fields_, it seems to me that a significant part of our uint32_t (originally PRUint32, of course) habit comes from the days when Tru64 Unix was the main 64-bit Gecko platform, therefore, we lacked proper 64-bit testing coverage. -- Henri Sivonen hsivo...@mozilla.com _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
