I don't think anyone wants to allow aliasing merely for its own sake. A lot of these flags were added just to keep builds working in the face of noisy compilers a long time ago. It would be good to retest with our current codebase and current compilers and see where we stand. If we can easily remove (or reduce) uses of this flag, I think that would be pretty uncontroversial. But if it turns out to be a huge amount of work, then as nice as it would be to do the cleanup, it might not be a justifiable use of time and opportunity cost.
On Fri, Feb 15, 2019 at 3:59 AM Henri Sivonen <hsivo...@mozilla.com> wrote: > > I happened to have a reason to run our build system under strace, and > I noticed that we pass -fno-strict-aliasing to clang. > > How committed are we to -fno-strict-aliasing? > > If we have no intention of getting rid of -fno-strict-aliasing, it > would make sense to document this at > https://developer.mozilla.org/en-US/docs/Mozilla/Using_CXX_in_Mozilla_code > and make it explicitly OK for Gecko developers not to worry about > type-based alias analysis UB--just like we don't worry about writing > exception-safe code. > > Debating in design/review or making an effort to avoid type-based > alias analysis UB is not a good use of time if we're committed to not > having type-based alias analysis. > > -- > Henri Sivonen > hsivo...@mozilla.com > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
