(From your next message it sounds like there's no disagreement here, but I wanted to get the reasoning written down)
On Sat, Jan 13, 2018 at 6:36 AM, Anthony Ramine <n.ox...@gmail.com> wrote: > I would much rather prefer if we just checked that we didn't use the Debug > impls of large types. The issue here is that it's difficult to tell at a glance how big a Debug impl will be, especially at the call site. Generics make this extra complicated, and even a couple of "small" stringifiers can easily add up. Moreover, a case-by-case analysis makes it hard to do enforcement with tooling. That said, if the tooling supports a whitelist, I'm totally fine with allowing exceptions when we have a good reason. I'm proposing some tooling in bug 1430678. > We could also just not derive them in release mode. > I believe debug!() statements are type-checked in release-mode compiles, so this would cause our logging code to break. > > In the PR you link, AFAICT you also removed some uses that were just very > small enums or even integers, which may not be necessary. > > > Le 13 janv. 2018 à 06:07, Bobby Holley <bobbyhol...@gmail.com> a écrit : > > > > Comments and alternative proposals welcome. > > _______________________________________________ > dev-servo mailing list > dev-se...@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-servo > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
