On Friday, May 23, 2014 at 3:29:48 AM UTC+2, Anthony Jones wrote: > Some of you may remember the discussion on clang-format and the `mach > clang-format` command. What we have in place right now is very temporary > but it is functional enough to give it a try. I have not put the effort > into upstreaming my changes. Depending on the feedback I receive I will > either: > > * Finish my existing changes and upstream them > * Remove the `mach clang-format` command altogether > * Do nothing > > I have personally found it useful. However I would like to hear from > other people who have tried it to help me decide what to do next. > > Anthony
I use `./mach clang-format` on basically every patch I write. It has eliminated the style nits that get picked up when people review my patches, at least when I remember to run it! I've considered writing a commit hook to run `./mach clang-format` before every commit, but haven't gotten around to it... `mach clang-format` is awesome, please don't remove it. As others have pointed out, it doesn't always produce nice formatting, but it's at least consistent, and enforces the major style guide recommendations. It's also liberating not having to waste brain power deciding how to format code. cpearce. _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
