On Wednesday, August 16, 2017 at 4:03:20 PM UTC-4, Nils Ohlmeier wrote: > > On Aug 16, 2017, at 07:23, James Graham <ja...@hoppipolla.co.uk> wrote: > > > > On 16/08/17 01:26, Nils Ohlmeier wrote: > >> I guess not a lot of people are aware of it, but for WebRTC we still have > >> two distinct implementations for the networking code. > >> So if I understand the impact here right we just lost test coverage for > >> probably a couple of thousand lines of code. > > […] > > > >> I’m not sure how others do it, but our low level C++ unit tests don’t have > >> an e10s mode at all. > >> Therefore we can’t simply delete the non-e10s WebRTC networking code > >> either (without loosing a ton of test coverage). > > > > If the networking code is only covered by C++ unit tests, there is separate > > code for non-e10s vs e10s, and the unit tests don't work in e10s mode > > doesn't that mean we currently don't have any test coverage for our > > shipping configuration on desktop? What am I missing? > > So we have mochitest-media which works as kind of integration test on a > higher level. They execute high level JS API tests, but also try to ensure > that the lower level networking pieces (the once which are exposed through > JS) match the expectations. > The mochitest-media got executed for e10s and non-e10s and therefore covered > both implementations. > > And then we have C++ unit tests, which cover a lot more corner cases of > different scenarios for networking. And yes these only work with non-e10s > right now. It would be a lot of work to create the same amount of tests with > a higher level test suite like mochitest to get the e10s coverage. Plus these > tests would probably take a lot execution time. > > Technically that leaves us with a somewhat blind spot for the coverage of > networking corner cases under e10s. I guess if there is a high demand for > turning off all non-e10s tests we need to look at how to get our C++ unit > tests working with something like e10s. > But until we can get to that I think we really should keep running > mochitest-media with e10s and without it. > > Best > Nils Ohlmeier
As a note, C++ tests will continue to run in non-e10s mode (cppunit, gtest)- there are no plans to run these as e10s; this is mostly referring to: mochitest*, web-platform-test*, reftest*, marionette* _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
