On Tue, Jul 11, 2017 at 3:04 AM, Chris Peterson <cpeter...@mozilla.com> wrote:
> On 7/10/17 4:48 PM, Xidorn Quan wrote: > >> The first thing comes to my mind is crash reports. It currently doesn't >> always include useful panic message from Rust, see for example [1] and [2]. >> Also for Stylo, we generate lots of code (including using bindgen and mako >> template system, bindgen is usually fine, but the code generated from >> template can contain lots of code logic), and when the crash happens inside >> generated code, it is pretty hard to understand what's going wrong, because >> there is no useful source link, see for example [3]. >> There are also issues from Rust side. I've always been using an optimized >> debug build locally (because that runs faster), and sometimes use Visual >> Studio to investigate issues. C++ code works fine with this configuration, >> but in Rust code, I cannot see any variable information. Stack backtrace >> seems to work fine to me, though. >> [1]https://crash-stats.mozilla.com/report/index/2abff06f- >> d969-4ba5-845b-a98410170708[2]https://crash-stats.mozilla. >> com/report/index/03718a9c-9d98-4832-b8a6-026220170706[3] >> https://crash-stats.mozilla.com/report/index/6b7d1d78- >> 8418-47ef-bee9-f49c20170710 >> > > Looking at those crash reports' signatures, we should probably add > `core::option::expect_failed` and `core::str::slice_error_fail` to > Socorro's list of function names to ignore [1]. Should Socorro ignore all > Rust core::* or std::* function names when searching the backtrace for a > useful signature? > I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1379089 last week for core::option::expect_failed. Cheers, Julien _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
