Thanks for bringing this up here, Ehsan.
I have to concur. For more then just trivial patches I usually ask for
a description of the patch in bugzilla - the commit message is usually
not enough. Anything that can help the review by understanding the
intention and structure of the patch helps a lot and often is even
necessary. The more the better. From time to time I r- a patch and ask
for this info if I find it too complicated to review without it.
Thank you as well!
-hb-
On 3/9/17 8:46 PM, Ehsan Akhgari wrote:
I review a large number of patches on a typical day, and usually I have to
spend a fair amount of time to just understand what the patch is doing. As
the patch author, you can do a lot to help make this easier by *writing
better commit messages*. Starting now, I'm going to try out a new practice
for a while: I'm going to first review the commit message of all patches,
and if I can't understand what the patch does by reading the commit message
before reading any of the code, I'll r- and ask for another version of the
patch.
I thank you in advance for your cooperation by writing great commit
messages. Happy hacking!
Cheers,
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
