I'm in favor of good commit messages, but I would note that current m-c convention really pushes against this, because people seem to feel that commit messages should be one line. Not sure what to do about that, but thought I would mention it.
-Ekr On Thu, Mar 9, 2017 at 12:10 PM, Boris Zbarsky <bzbar...@mit.edu> wrote: > On 3/9/17 2:46 PM, Ehsan Akhgari wrote: > >> Starting now, I'm going to try out a new practice >> for a while: I'm going to first review the commit message of all patches, >> and if I can't understand what the patch does by reading the commit >> message >> before reading any of the code, I'll r- and ask for another version of the >> patch. >> > > I will be doing likewise. > > I believe dbaron does this already. > > I encourage others to do this too. > > -Boris > > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
