I met with Mike earlier today and answered a few of his mechanics questions (with the help of Osmose)[0].
Timing for his add-on is end of Q3. I've taken the action item to help coordinate testing around this add-on over the next couple of weeks. Thanks! [0] https://pad.mocotoolsprod.net/p/cbs2hKntP9 On Mon, Jun 27, 2016 at 1:40 PM, Mike Taylor <mi...@mozilla.com> wrote: > On 6/27/16 3:20 PM, Justin Dolske wrote: > >> I'm asking because this is code shipping to end-users, so I'd expect it >> to adhere to basically the same engineering standards as code that ships >> as part of baseline Firefox. AFAIK this is the first time that's really >> been a question -- our other system addons (Hello, Pocket) started off >> in Firefox, and just changed their delivery vehicle. >> >> To be more specific: >> >> * Who are the people that will be reviewing code that ships in this >> addon? I don't see anything in the docs about code review or who can do >> it. Will there be a module? Would the relevant platform reviewers be >> used when shimming in DOM APIs? >> > > I don't know how the module system works wrt go faster add-ons. But maybe > someone can add some clarity around this this. > > I'd likely be reviewing patches written against sites, within our team. > And we'd be asking people with more Firefox/XPCOM/go faster experience to > review the site patching infrastructure. We'd absolutely be asking for > review from DOM peers if and when we shim any APIs. If someone wants to > step up and volunteer to review all our patches, that's also great. > > * The docs do expand a bit on testing, but it sounds like a one-time QA >> signoff. That's an important part, but I don't see anything about >> automated / ongoing tests (against product code or website code). For >> example, if a Gecko change breaks something the addon is relying on, >> when will that be noticed? Or if the addon's patch for a site stops >> working (or, worse, breaks it!) due to a change the site deploys after >> the addon is released, when will that be noticed? >> > > I sort of expanded on that in my reply to Benjamin. Right now it's a very > hand-wavey TODO item here: < > https://wiki.mozilla.org/Compatibility/Go_Faster_Addon#TODO> > > We don't plan on shipping site patches without this kind of ongoing sites > -- sites change all the time, and often developers fix bugs without letting > us know (once we're at the outreach stage). > > * Similarly to correctness testing, how is performance testing dealt with? >> > > For this go faster add-on, or go faster add-ons in general? > > > -- > Mike Taylor > Web Compat, Mozilla > -- Cory Price /ckprice _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
