I'm not really clear what part of those docs covers my questions. Either I'm missing it, or my question wasn't clear...
I'm asking because this is code shipping to end-users, so I'd expect it to adhere to basically the same engineering standards as code that ships as part of baseline Firefox. AFAIK this is the first time that's really been a question -- our other system addons (Hello, Pocket) started off in Firefox, and just changed their delivery vehicle. To be more specific: * Who are the people that will be reviewing code that ships in this addon? I don't see anything in the docs about code review or who can do it. Will there be a module? Would the relevant platform reviewers be used when shimming in DOM APIs? * The docs do expand a bit on testing, but it sounds like a one-time QA signoff. That's an important part, but I don't see anything about automated / ongoing tests (against product code or website code). For example, if a Gecko change breaks something the addon is relying on, when will that be noticed? Or if the addon's patch for a site stops working (or, worse, breaks it!) due to a change the site deploys after the addon is released, when will that be noticed? * Similarly to correctness testing, how is performance testing dealt with? Justin On Mon, Jun 27, 2016 at 12:09 PM, Cory Price <cpr...@mozilla.com> wrote: > The answer was focused on the policy question which should be covered for > the most part in the documentation. With respect to individual roles and > responsibilities for this add-on, I've added it to the agenda in the > aforementioned team check-in. > > On Mon, Jun 27, 2016 at 11:45 AM, Benjamin Smedberg <bsmedb...@mozilla.com > > wrote: > >> >> On Mon, Jun 27, 2016 at 2:26 PM, Cory Price <cpr...@mozilla.com> wrote: >> >>> >>> On Mon, Jun 27, 2016 at 11:05 AM, Justin Dolske <dol...@mozilla.com> >>> wrote: >>> >>>> What's the policy for reviews and testing with this addon? >>>> >>> >>> You can see the current process for deploying things in the Go Faster >>> documentation (Wiki <https://wiki.mozilla.org/Firefox/Go_Faster>, Release >>> Process >>> <https://docs.google.com/document/d/1x27I7hAmWDWiqk3o3YC3fklhE3N59bdgHCQHF5p_lkU/edit#> >>> ). >>> >>> I've also added this to our system add-on pipeline >>> <https://trello.com/b/moJCpVCD/go-faster-system-add-on-pipeline> which >>> we discuss in our weekly meetings (invited Mike/Justin). >>> >> >> This seems like an inadequate answer to the particular question: who in >> particular is the module owner of this code, who is responsible for doing >> code review? And who is the QA/QE lead for this addon and what kind of >> systems will be used to determine whether a particular webcompat tweak is >> working both before before and after deployment? >> >> --BDS >> >> -- >> Benjamin Smedberg >> Engineering Manager, Firefox >> >> > > > -- > Cory Price > /ckprice > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
