On Mon, Apr 4, 2016 at 10:26 PM, Mark Côté <mc...@mozilla.com> wrote:
> On 2016-04-04 8:41 PM, Eric Rescorla wrote: > > On Mon, Apr 4, 2016 at 9:23 PM, Mark Côté <mc...@mozilla.com> wrote: > >> To answer the original question, though, at this time we have no plans > >> to completely do away with the squashed-commit view. However, in the > >> interests of ensuring that the commits that will land are the ones > >> reviewed, we are thinking of making the squashed diff read-only--and > >> also more obvious and easy to find, probably by not making it a proper > >> review request, just a diff linked off the commit table (the layout of > >> which we also have plans to improve). I agree that seeing the entirety > >> of a series of commits in a single diff can be useful. > > > > > > What does read-only mean? If it's that you can't comment on it, then that > > doesn't work. > > That is, after we have support for squash-on-push. Ah, I understand. At that point we > wouldn't need squashed diffs for your workflow, only for micro commits > where the reviewer wants to see a high-level view. Or am I > misunderstanding? > Yes, this seems fine. -Ekr > > Mark > > > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
