On 2014-10-16, 8:00 PM, Trevor Saunders wrote:
On Fri, Oct 17, 2014 at 09:32:20AM +1100, Nicholas Nethercote wrote:
On Thu, Oct 16, 2014 at 11:32 PM, Nicholas Nethercote
<n.netherc...@gmail.com> wrote:
I was wondering what people think is the worst piece of code in the
entire Mozilla codebase. I'll leave the exact meanings of "worst" and
"piece of code" unspecified...
Thanks for the replies so far! I deliberately left this question vague
to see what kind of responses people would give. But mostly I'm
interested in code whose awfulness impacts users in a serious way.
Ones where refactoring/rewriting efforts would be valuable. That
excludes code that no longer exists :)
With this in mind, a function that is hideous but non-buggy and
doesn't cause maintenance problems (e.g. because the hideousness
doesn't leak too far) wouldn't qualify as bad. In comparison, a
sub-system with frequent subtle correctness issues would be very bad.
For that I'd tend to agree with ehsan editor/ and the selection bits in
layout/.
FWIW the selection code is much better these days. There are edge case
bugs in it for sure, but I don't think it's the worst piece of Mozilla
code (close contender though.)
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
