On Fri, Jun 6, 2014 at 7:10 PM, Boris Zbarsky <bzbar...@mit.edu> wrote: > On 6/6/14, 8:42 PM, Jonas Sicking wrote: >> >> I definitely understand that it'll be a pain to convert existing tests >> that rely on the relaxed matching. > > > Yes. We have about 3300 failing test assertions with is() using ===, and > the vast majority are string-vs-number. > > All I'm saying is that we could allow that to keep working and tighten up > is() for the other cases much faster than we can whack all the moles. ;)
If that counts as low-hanging fruit then that's certainly a step in the right direction. The question is what to do as step 2. >> But rather than making the >> implementation of is() be more complex and/or more relaxed, could we >> instead convert those tests to either >> >> is_relaxed(a, b) >> or >> ok(a == b) > > Yes, we could. It's a largish number of tests (several hundred; a number > have multiple assertions in a single test, so there are definitely many > fewer than 3000 _tests_ involved). > > On the other hand, if you're volunteering to review patches, I'll make sure > they get written... ;) I'm not sure that I'm prepared to take them on all by myself :) But I can certainly help. / Jonas _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
