On 6/6/14, 12:21 PM, Boris Zbarsky wrote:
That will be the big question, yes.
https://tbpl.mozilla.org/?tree=Try&rev=e26ab6d5e1e0 says we have quite a
number of things that are in fact assuming that 5 and "5" should test
is(). I'm not sure how much I like throwing in tons of toString() for
that case.
There are also tests that explicitly compare "0.40" with 0.4 and expect
that to pass. I didn't look to see whether the formatting of the "0.40"
was meaningful or the result of using toFixed() to get rounding.
We also have the following things that I think should in fact be fixed
no matter what we do with number vs string:
1) null vs undefined
2) Location objects vs strings.
3) DOMTokenList objects vs strings
4) DOM nodes vs stuff like "[object HTMLDivElement]" (does the test
really not care _which_ div it got??)
5) Arrays vs strings (e.g. is(["foo"], "foo")
6) Date objects vs strings
7) 0 vs false (in bc1, complete with "unknown test url", yay).
8) Various objects vs strings (akin to #4 but for Xray wrappers and
whatnot).
-boris
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
