I still don't believe either of you :) Obviously my position isn't "let's make it it more frustrating to write tests"; I think you're both vastly overstating the costs of switching to a slightly different, similar API. Any change is initially jarring, but I just don't buy that this change would cause it to be more annoying to write tests in the long term.
But really that doesn't matter. Here are some high-level points we can probably agree on: - benefits to shared API/implementation seem uncontroversial - specifically, consistency between mochitest/SimpleTest-based harnesses (mochitest-plain/mochitest-chrome/mochitest-browser) and xpcshell tests is what we care about primarily. I don't think we should expand the scope of this discussion beyond that to e.g. testharness.js. - I'm not particularly attached to CommonJS assertions, and probably actually favor using the existing SimpleTest API as "the one true test assertion API" since it's more familiar to me and seems to be working well. Sounds like bz/ehsan/sicking all agree, and it should represent a net reduction in work (since it's somewhat more trivial to move existing tests over). Assuming agreement across those, that suggests we should modify Assert.jsm to use the SimpleTest API instead, and continue with this plan to gradually encourage use of Assert.jsm for the mochitest-based harnesses and xpcshell. (Separately, we could then perhaps address any shortcomings with the existing SimpleTest assertions, and other issues sicking identified). Gavin On Tue, Jun 3, 2014 at 12:41 PM, Bobby Holley <bobbyhol...@gmail.com> wrote: > On Tue, Jun 3, 2014 at 12:31 PM, Boris Zbarsky <bzbar...@mit.edu> wrote: > >> I can certainly buy "it's longer than what I'm >>> used to", and even "incremental effort is required" - just not >>> "incremental effort is required and that effort is non-negligible >>> given other factors" >>> >> >> Purely subjectively, it's non-negligible. The more frustrating writing a >> test is, the less I want to do it, and the more I'll skimp on testing >> exhaustively... Maybe that's a personal failing of mine, but I suspect not. >> >> The way I see it, anything that makes the test-writing experience more >> frustrating is a bar to us having better test coverage. > > > +1 to all of this. > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
