I don't use Terminals for programming, I have the space for 100 chars. I also usually don't open more than one window at a time. I usually just switch between files very quickly if I need to correlate something. Everytime single time I create a patch that touches a lot of code Gecko, I feel like 80 chars is just not enough. My experience is obviously kind of skewed, because I mostly edit function definitions in away that makes them longer, i.e. replace JS::Value with JS::Handle<JS::Value>. I feel like a thousand times I just barely miss the 80 char limit and I have to start wrapping some arguments around, which can be really annoying, because suddenly you also have to move something else etc.
I don't really care about 2/4 spaces, I just press tab anyway. On Fri, Jan 17, 2014 at 3:03 AM, <gokoproj...@gmail.com> wrote: > re 80char vs 100chars: > > I am for 80 chars. > > If the argument for expanding to 100 or more is that screen is getting > wider, then the benefit of wide screen is able to fit multiple terminals in > one window. For normal workflow, I'd split my windows into two or > terminals, depending on what I am doing, so I don't see any benefit for > increasing the limit. > > > re braces for single statement: > > I am for always braces. > > If multi-statement logical statement requires braces pair, why make > exception to the single logical branch? > > if (...) > do_stuff > > vs > > if (...) { > do_stuff > } > > and if I need to add more statements (like adding debug), I don't need to > go back and add { } again which can be as difficult as adding { } in the > first place (but that's a one-time cost). I am not sure why this is not a > problem... I know, it sounds lazy, but since we are mentioning > productivity.... > > > re 2 spaces vs 4 spaces: > > I'd keep with two-space. > > I come from Python world and after working on Firefox for a while I am > used to two-space instead of four-space in Firefox. > > Does four-space increase productivity? My take on this is that not > necessarily and productivity depends on the tool the developer is using. If > you use vim you can set the tab indentation to four spaces. You can also > set language-specific indentation. I can't speak of other editors and IDEs > out there and we certainly can't make everyone happy. > > Chromium has the following style guide: > > "Python code should follow PEP-8, except that Chromium uses two-space > indentation instead of four-space indentation, and it uses MixedCase for > method names and function names instead of lower_case_with_underscores" > > I am not saying we have to stick with two-space because Chromium uses > two-space since Linux kernel is 8-space, but two-space is not rare at all > (I am not sure Chromium's decision is influenced by people who started > Chrome in the first place, as they had/have been firefox contributors). > > Finally, another thing to consider when we write a style checker is to > consider this way of wrapping lines: > > const SOME_REGEX_CONSTANT = new RegExp("^(str1|str2" + > "str3|str4"); > > const SOME_KEYWORD_TO_SET = "hello world" + > "what is going on?" > > > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform