I think we should do more than encourage: we should back out for all style guide violations. Period. We could even enforce that during upload to a review tool, perhaps.
However. This has to be done on a per-module basis (or even more fine-grained: different parts of, e.g., SpiderMonkey have slightly different styles). Different modules have vastly different styles, ranging from where to put braces over how much to indent to how to name fields/ vars/ arguments. I very, very much doubt we'll ever be able to reconcile these differences. (Partly because some of the affected people from different modules sit in the same offices, and would probably get into fist fights.) On Thu, Dec 19, 2013 at 6:48 PM, Martin Thomson <m...@mozilla.com> wrote: > No question. But there are ways to encourage people to stop digging in. > If you provide tools to help those who want to come into the light, say a > moz.build option that autoformatted or checked against the general > formatting rules, then that might be sufficient. I think that bug 939350 > shows a template for that. > > ----- Original Message ----- > From: "Bobby Holley" <bobbyhol...@gmail.com> > To: "Martin Thomson" <m...@mozilla.com> > Cc: "Till Schneidereit" <t...@tillschneidereit.net>, "Mike Hommey" < > m...@glandium.org>, "Ehsan Akhgari" <ehsan.akhg...@gmail.com>, > dev-platform@lists.mozilla.org, "Andrea Marchesini" < > amarches...@mozilla.com> > Sent: Thursday, December 19, 2013 9:43:34 AM > Subject: On the usefulness of style guides (Was: style guide proposal) > > Attempting to fork the thread. Please reply here if you want to bikeshed > on this topic in general. > > > On Thu, Dec 19, 2013 at 9:38 AM, Martin Thomson <m...@mozilla.com> wrote: > > > Here's what I've done for the last few projects I've been on: > > > > * Taken the off-the-shelf formatter. > > * Taken the default configuration. > > * Applied that frequently. > > * Moved on to more important things. > > > > Gecko is a massive project, and has much more entrenched style decisions > than other projects. This is not going to fly, I assure you. > > bholley > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
