On Wed 04 Dec 2013 04:21:33 AM PST, Ted Mielczarek wrote: > On 12/3/2013 8:02 PM, Nicholas Nethercote wrote: >> 3) Runs on mozilla-central and all trees that merge into it > > This is something that Release Engineering needs to fix. You've already > got a bug open, so you should touch base with them.
This is a buildbot-configs modification, though note that exactly what you do here might change if you switch to mozharness. >> 6) Outputs failures in a TBPL-starrable format >> >> Currently the Valgrind builds show up as green, even if there are failures >> (https://bugzilla.mozilla.org/show_bug.cgi?id=823787). That needs fixing. If you switched to mozharness, I would know how to do this. (There's a set of regexes that get run on the log to find errors/warnings.) Non-mozharness, it's similar, but it goes into buildbotcustom. Somewhere. Maybe. I don't remember for sure. bhearsum would know. There's probably a simple hackaround to postprocess the output and add "TEST-UNEXPECTED-FAILURE" or something to the valgrind error lines. ted would know, I think. >> Again, what code needs to change for this to happen? Who do I need to talk >> to? > You'd likely need to make changes to the script that does the Valgrind > runs, which is currently a shell script (which is horrible). Moving this > to a mozharness script would probably make life easier, but also may be > significant effort. You CCed a bunch of sheriffs on your original mail, > they're best qualified to answer the specific details of this piece. We have mozharness scripts for doing b2g builds right now, though it might be fairly straightforward to start from my linux64-br-haz mozharness script. It does a full build as part of the analysis (though through a couple of layers of indirection you don't need.) It even does the build through mach, so if you create a mach target, you could just call that. It's in mozharness/scripts/spidermonkey_build.py. (And the name is a lie, since the same script can do either spidermonkey-only builds or full browser builds.) One ugly thing right now with these sorts of mozharness builds is that the straightforward way to add them to buildbot-configs is to call them a different platform (parallel with linux64, macosx64, win32, etc.) That also affects the trychooser syntax for them. tbpl can show them wherever you want, though. A few items to add to your list: - display them on tbpl in the right place (perhaps they're already there?) - add them to the trychooser web UI - add them to one or more of the trychooser hg extensions _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
