On 16:34, Tue, 23 Apr, Gervase Markham wrote:
On 23/04/13 10:17, Ed Morley wrote:Given that local machine time scales linearly with the rate at which we hire devs (unlike our automation capacity), I think we need to work out why (some) people aren't doing things like compiling locally and running their team's directory of tests before pushing. I would hazard a guess that if we improved incremental build times & created mach commands to simplify the edit-compile-test loop, then we could cut out many of these obvious inbound bustage cases.That would be the carrot. The stick would be finding some way of finding out whether a changeset was pushed to try before it was pushed to m-i. If a developer failed to push to try and then broke m-i, we could (in a pre-commit hook) refuse to let them commit to m-i in future unless they'd already pushed to try. For a week, on first offence, a month on subsequent offences :-) This, of course, is predicated on being able to detect in real time whether a changeset being pushed to m-i has previously been pushed to try.
We've considered enforcing this using some cryptographic token. After you push to try and get good results, the system gives you a token you need to include in your commit to m-i.
Alternatively, you could indicate the try revision you pushed, and we could look up the results and refuse the commit based on your build/tests results on try, or if you commit to m-i is "too different" than the push to try.
Cheers, Chris
signature.asc
Description: Digital signature
_______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
