On 28/09/12 22:42, Bobby Holley wrote:
Hi All,
I'd like to propose that we discourage the use of all-platform try builds.
I cringe a little bit every time I see a full column of orange on a try
push.
You should rejoice, for a full column of orange on Inbound was avoided!
This is why we have Try and why we have *tests* on Try; to avoid broken
landings on branches others depend on; to avoid wasting other peoples' time.
More often than not, it means that we spent an order of magnitude
extra compute time verifying that, indeed, the push caused a given test to
fail on every single platform.
This is indeed unfortunate. However I'd prefer to add more capacity to
our test infrastructure, rather than discourage developers from properly
testing before landing.
If Try is hogging resources needed by Inbound, we should lower the
priority of Try.
In my experience, a debug-only build on a single platform (say, linux64)
gives me about 80% of the information that I get from |-b do -p all|. If a
push goes entirely green on a given platform, the chances are decent that
it will go green everywhere. If it goes orange, our infrastructure is
spared the formality of reproducing the failure in every configuration. If
the orange is questionably intermittent, the job can be retriggered
(several times) with a single click of the '+' button on the build summary.
Developers should run tests locally for the modules affected by their
code changes before pushing to Try. Try is for catching the things you
can't easily test locally, like that random failure on platforms you
can't tests on, or failures in a seemingly unrelated modules that you
wouldn't think to test on.
Single-platform builds certainly won't catch those pesky WinXP-only
browser-chrome oranges. But that's what mozilla-inbound is for.
Inbound is not for catching pesky WinXP-only failures. Try is.
So what if you have to wait overnight for a Try run to complete on all
platforms? Few patches so urgently need to land that they can't wait
until tomorrow to land.
I'd even go as far to suggest that we should *require* a green Try run
before allowing people to land, for everything except "simple" changes.
Regards,
Chris P.
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
