[ http://jira.magnolia.info/browse/MAGNOLIA-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18357#action_18357 ]
Vasko Gjurovski commented on MAGNOLIA-2124: ------------------------------------------- I just managed to read through all of Genuine Overvie (it is loong :) ), and as managed to there an important feature in i18n concept is to be able to provide a view of two languages at the same time, in order to make it more accessible for translator. Well, as Stojan and Philipp said somwere above, a nice tab level view of the language would be enough. For example a combo for the languages at the top of the dialog? It is not quite the feature you were asking in http://wiki.magnolia.info/display/DEV/Genuine+Overview, but a simple keyboard switching (since it is planed to be supported in the next editions for Admin Central) such as Ctrl+L would be switching between the fallback language and the curent language (the language that needs to be translated). > I18nContentSupport for dialogs > ------------------------------ > > Key: MAGNOLIA-2124 > URL: http://jira.magnolia.info/browse/MAGNOLIA-2124 > Project: Magnolia > Issue Type: Improvement > Components: gui > Affects Versions: 3.6 > Environment: Irrelevant > Reporter: Stojan Peshov > Assignee: Philipp Bracher > Fix For: 3.6.x > > Attachments: i18n.patch, i18supportForDialogs.patch > > > In MAGNOLIA-1431 it is stated that we should make copies of dialog controls > (or even locale tabs) with locale extensions if we want to have i18n aware > dialog. > This solution leads as to many copies (tabs) if we want to cover many > languages. > Therefore, we've modified the initialization of dialogs in order to have one > dialog for all languages. > The solution works like this: > When a page is displayed i18nContentSupportFilter sets the current locale and > when a dialog is opened all the control's names are suffixed with the locale > (if the locale is different than the fallback locale) > ex. a dialog with edit control named "text" will become "text_[locale]". > The rest of the job remains to the Save handler which creates the localized > content (nodeDatas). > If you edit the dialog then the content of the current language is filled in > the controls. > This way we have only one dialog and unlimited number of languages, without > the need of creating additional tabs (or controls). > Note: This way there is no possibility to edit more than one language at > once. > For this functionality we modified the following: > - DialogControlImpl.initializeConfig > - I18nContentSupportFilter > - DefaultI18nContentSupport > - I18nContentSupport > All of the classes have minor changes, that don't affect other > functionalities. > We attached the patch and hope that you'll like it. :) > p.s. we also have created a language chooser (changer) tag that successfully > implements the suggested solution -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia.info/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ---------------------------------------------------------------- for list details see http://documentation.magnolia.info/ ----------------------------------------------------------------