[
http://jira.magnolia.info/browse/MAGNOLIA-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840#action_16840
]
Stojan Peshov commented on MAGNOLIA-2124:
-----------------------------------------
That is very subjective idea.
- Why wouldn't I want to have localized activation dates? Wouldn't that mean
that my language2 version activates separately from the language1 version?
- Don't tell me that you haven't struggled with localized images yet. Greatest
example would be (language) country flag.
- Not to mention localized flash or animated gifs, banners (very common in
advertising). And you can always use DMS if you want to reuse the same image.
- I even have use-case for the links: I want to link to a site which has two
languages just as I do.
Maybe it's easier to change the language in the dialog, but what happens when
you have 10+ languages?
You will copy your dialog tabs 10+ times multiplied by the number of the
dialogs, instead of having just one dialog.
We can also achieve to change the language in the dialog by adding a combo with
the languages above the tabs in order not to change the language and then edit
the content.
And I think the best feature of all is that if you leave some nodeData field
empty in the secondary language, the page will always use the primary
(fallback) language field. This is also an answer to your images, links, dates
problem.
We already have implemented this concept on a live web site (jug.mk) and works
just fine.
I'm willing to contribute more on this issue, but I still wait for a positive
answer from the Magnolians.
Regards
> I18nContentSupport for dialogs
> ------------------------------
>
> Key: MAGNOLIA-2124
> URL: http://jira.magnolia.info/browse/MAGNOLIA-2124
> Project: Magnolia
> Issue Type: Improvement
> Components: gui
> Affects Versions: 3.6
> Environment: Irrelevant
> Reporter: Stojan Peshov
> Assignee: Boris Kraft
> Fix For: 3.6
>
> Attachments: i18supportForDialogs.patch
>
>
> In MAGNOLIA-1431 it is stated that we should make copies of dialog controls
> (or even locale tabs) with locale extensions if we want to have i18n aware
> dialog.
> This solution leads as to many copies (tabs) if we want to cover many
> languages.
> Therefore, we've modified the initialization of dialogs in order to have one
> dialog for all languages.
> The solution works like this:
> When a page is displayed i18nContentSupportFilter sets the current locale and
> when a dialog is opened all the control's names are suffixed with the locale
> (if the locale is different than the fallback locale)
> ex. a dialog with edit control named "text" will become "text_[locale]".
> The rest of the job remains to the Save handler which creates the localized
> content (nodeDatas).
> If you edit the dialog then the content of the current language is filled in
> the controls.
> This way we have only one dialog and unlimited number of languages, without
> the need of creating additional tabs (or controls).
> Note: This way there is no possibility to edit more than one language at
> once.
> For this functionality we modified the following:
> - DialogControlImpl.initializeConfig
> - I18nContentSupportFilter
> - DefaultI18nContentSupport
> - I18nContentSupport
> All of the classes have minor changes, that don't affect other
> functionalities.
> We attached the patch and hope that you'll like it. :)
> p.s. we also have created a language chooser (changer) tag that successfully
> implements the suggested solution
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia.info/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
----------------------------------------------------------------
for list details see
http://documentation.magnolia.info/
----------------------------------------------------------------
