On 8/20/25 06:04, Dag-Erling Smørgrav wrote:
Konstantin Belousov <kostik...@gmail.com> writes:
Dag-Erling Smørgrav <d...@freebsd.org> writes:
Konstantin Belousov <kostik...@gmail.com> writes:
Aymeric Wibo <obi...@freebsd.org> writes:
libifconfig: Remove ifconfig_set_fib and ifconfig_sfp_id_is_qsfp
This breaks the ABI, of course.
No, it does not. Please take the time to check before throwing
accusations around.
If a symbol is removed from the library export list, its ABI is broken.
Again, please *take the time to check* before lashing out. I promise
you we'll still be here when you get back.
Well, in kib's defense, it is rather stupid to have a symbol map that is
never used and thus _never verified_ checked into the tree for an internal
lib. The bug was adding this symbol map in the first place, and it should
probably be deleted. If at some point we decide to convert this library
to actually be a shared library, that is the point at which we would have
an ABI we are committed to and is when we should add a symbol map.
This was arguably broken on the initial import back in 2016 as libifc as
that Makefile set SHLIBDIR and SHLIB_MAJOR, but also set NO_PIC to
disable the shared library build. I think adding the version map just
built on this mistake, and we should remove all the shlib cruft and symbol
versions until this library has a stable ABI.
--
John Baldwin
