On Tue, Aug 19, 2025 at 11:09:38PM +0000, Aymeric Wibo wrote: > The branch main has been updated by obiwac: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=75acf71786f201093b76f45eff03a8665fb79a72 > > commit 75acf71786f201093b76f45eff03a8665fb79a72 > Author: Muhammad Saheed <sah...@freebsd.org> > AuthorDate: 2025-08-19 23:06:53 +0000 > Commit: Aymeric Wibo <obi...@freebsd.org> > CommitDate: 2025-08-19 23:07:15 +0000 > > libifconfig: Remove ifconfig_set_fib and ifconfig_sfp_id_is_qsfp > > Remove the declaration of ifconfig_set_fib from libifconfig.h as it had > no definition. > > ifconfig_sfp_id_is_qsfp is defined as a static header function in > libifconfig_sfp.h and doesn't generate a symbol. > > Both have been removed from Symbol.map. > > Reviewed by: obiwac, mckusick (mentor) > Approved by: obiwac, mckusick (mentor) > Sponsored by: Google LLC (GSoC) > Differential Revision: https://reviews.freebsd.org/D50666 > --- > lib/libifconfig/Symbol.map | 2 -- > lib/libifconfig/libifconfig.h | 1 - > 2 files changed, 3 deletions(-) > > diff --git a/lib/libifconfig/Symbol.map b/lib/libifconfig/Symbol.map > index 2d80fb31652a..2e11ff963909 100644 > --- a/lib/libifconfig/Symbol.map > +++ b/lib/libifconfig/Symbol.map > @@ -40,7 +40,6 @@ FBSD_1.6 { > ifconfig_open; > ifconfig_set_capability; > ifconfig_set_description; > - ifconfig_set_fib; > ifconfig_set_metric; > ifconfig_set_mtu; > ifconfig_set_name; > @@ -81,7 +80,6 @@ FBSD_1.6 { > ifconfig_sfp_fc_speed_symbol; > ifconfig_sfp_id_description; > ifconfig_sfp_id_display; > - ifconfig_sfp_id_is_qsfp; > ifconfig_sfp_id_symbol; > ifconfig_sfp_rev_description; > ifconfig_sfp_rev_symbol;
This breaks the ABI, of course. Or, it makes no sense to have the overhead of symbol versioning if it is fine to break the ABI. Symbol removal should have resulted in the library version bump.
