Alexander Leidinger <alexan...@leidinger.net> writes: > You change from "no fork+exec if the file doesn't exist" (due to "if" > and "[" being shell-builtins) to "always fork+exec". On fast machines > surely not an issue, on slow ones, it may make a difference (I have an > old amd64 machine at an ISP which takes days to do a buildworld with > -j2 due to not much memory, only 2 cores, old HDs, and other stuff > going on in parallel).
Have you measured this? Because the whole point of clean_dep() is that the file it looks for nearly always exists. It's the grep we're not sure of. So checking if the file exists is nearly always a waste. > While the .depend.* namespace is surely controlled by us, would it > make sense to change the glob to ".{o,pico}" instead of ".*o" instead > to prevent unexpected surprises in the future? Our sh does not support the {} syntax. Besides, what would it change? What else would match .*o but not .{o,pico}? DES -- Dag-Erling Smørgrav - d...@des.no