Hi Rico,

Thanks for the clarifications!

> 1) 2) 3) 6) are packaging bugs regarding Java support
> Those are needed to allow Java support to be disabled on specific archs if 
> needed.
> Fortunately this wasn't required yet while the already applied mitigations to 
> the bridgetests still are sufficient.

So, it does look like this is not _required_ right now, correct?
(i.e., no archs are getting Java support disabled in this SRU.)

I take this from your comment ("if needed" and "wasn't required yet")
_and_ `d/rules` assignments of OOO_BASE_ARCHS and OOO_REPORTBUILDER_ARCHS,
which remain the same value ("amd64 arm64 armhf ppc64el riscv64 s390x").

In this case, I guess such changes should not be included in this SRU,
but left for when it is actually needed; maybe others can comment too.

And perhaps a separate bug report with more details would be recommended,
but please do not work on this at the moment, while others don't comment.

> 4) 5) follow the upstream CMIS changes
> Upstream bumped the internal requirement of libcmis which finally allows the 
> proper CMIS service support.
> Unfortunately it had to be disabled before because it was broken.

Understood.

I reviewed some of the docs/changes related to this, and this scenario
is more complex, since this (CMIS support) is a feature, with different
considerations for SRU (e.g., support in LTS and newer interim releases).

I'll have to ask for others with more experience in such case to comment,
but these are some thoughts for now:

CMIS is a standard related to a feature for opening/saving files on remote 
servers [1].
"LibreOffice supports many document servers ... that implement the OASIS CMIS 
standard."

[1] https://help.libreoffice.org/7.6/en-US/text/shared/guide/cmis-
remote-files.html

In general, features only land in the development release, until feature freeze 
[2],
but there are cases for stable releases as well, when considering LTS releases: 
[3]

[2] https://wiki.ubuntu.com/FeatureFreeze
[3] https://wiki.ubuntu.com/StableReleaseUpdates#Other_safe_cases

"""
For Long Term Support releases we sometimes want to introduce new features.
...
To avoid regressions on upgrade, any such feature must then also be added to 
any newer supported Ubuntu release.
...
For new upstream versions of packages which provide new features, but don't fix 
critical bugs, a backport should be requested instead. 
"""

So, theoretically, enabling CMIS in Mantic could meet the requirement to have it
in Jammy, and it is (jammy-updates 1:7.3.7-0ubuntu0.22.04.3 has ENABLE_CMIS=y).

It just turns out to be disabled in Lunar (lunar-updates 
4:7.5.8-0ubuntu0.23.04.1
has ENABLE_LIBCMIS=n, I guess it might be due to issues/broken as you 
mentioned?),
so there's some intermediary release with it disabled.

> (continuing)
> Upstream chose Openssl as official choice for this feature/combination which 
> was followed here.
> But it would be possible to continue using gnutls if the SRU requires it.

Ack, thanks for clarifying.
In this case, if libcurl4-gnutls/openssl were only being used due to 
ENABLE_CMIS,
which is disabled in mantic-release, then maybe we could change it, as it would 
be
effectively the only usage of it.
But it turns out it's apparently already used due to ENABLE_WEBDAV, so changing 
it
would affect something already present in mantic-release, so at least initially,
keeping it as-is sounds better -- unless there's an upstream rationale that 
gives
good reasons for switching, sure (and assessing/dealing with the change in 
Mantic).

I'll ask for an additional review on these points.

Thanks again for all your work on this SRU and its review!

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to libreoffice in Ubuntu.
https://bugs.launchpad.net/bugs/2044019

Title:
  [SRU] libreoffice 7.6.3 for mantic

Status in libreoffice package in Ubuntu:
  Fix Released
Status in libreoffice source package in Mantic:
  Incomplete

Bug description:
  [Impact]

   * LibreOffice 7.6.3 is in its third bugfix release of the 7.6 line:
       https://wiki.documentfoundation.org/ReleasePlan/7.6#7.6.3_release

   * Version 7.6.2 is currently released in mantic. For a list of fixed bugs 
compared to 7.6.2 see the list of bugs fixed in the release candidates of 7.6.3 
(that's a total of 116 bugs):
       https://wiki.documentfoundation.org/Releases/7.6.3/RC1#List_of_fixed_bugs
       https://wiki.documentfoundation.org/Releases/7.6.3/RC2#List_of_fixed_bugs

       7.6.3 RC2 is identical to the 7.6.3 release

   * Given the nature of the project, the complexity of the codebase and
  the high level of quality assurance upstream, it is preferable to SRU
  a minor release rather than cherry-pick selected bug fixes.

  [Testing]

   * Upstream testing. Bugs fixed upstream typically include
  unit/regression tests, and the release itself is extensively exercised
  (both in an automated manner and manually).

    * A recent set of upstream's automated jenkins testing can be found here:
      https://ci.libreoffice.org/job/gerrit_76/1459/

    * More information about the upstream QA testing can be found here:
      * Automated tests
        https://wiki.documentfoundation.org/QA/Testing/Automated_Tests
      * Automated UI tests
        https://wiki.documentfoundation.org/Development/UITests
      * Regression tests
        https://wiki.documentfoundation.org/QA/Testing/Regression_Tests
      * Feature tests
        https://wiki.documentfoundation.org/QA/Testing/Feature_Tests

   * Launchpad testing. The libreoffice packages include autopkgtests that were 
run and verified as passing.
      Tested build can be found at 
https://launchpad.net/~ricotz/+archive/ubuntu/ppa/+sourcepub/15409029/+listing-archive-extra
      * [amd64] 
https://autopkgtest.ubuntu.com/results/autopkgtest-mantic-ricotz-ppa/mantic/amd64/libr/libreoffice/20231204_140350_e86f9@/log.gz
      * [arm64] 
https://autopkgtest.ubuntu.com/results/autopkgtest-mantic-ricotz-ppa/mantic/arm64/libr/libreoffice/20231204_121007_4cf76@/log.gz
      * [armhf] ... (autopkgtests infra problems on this arch)
      * [ppc64el] 
https://autopkgtest.ubuntu.com/results/autopkgtest-mantic-ricotz-ppa/mantic/ppc64el/libr/libreoffice/20231204_113322_18e7a@/log.gz
      * [riscv64] not available
      * [s390x] 
https://autopkgtest.ubuntu.com/results/autopkgtest-mantic-ricotz-ppa/mantic/s390x/libr/libreoffice/20231204_115147_339ff@/log.gz
   * General smoke testing of all the applications in the office suite were 
carried out by going through the manual testplan as documented by: 
https://wiki.ubuntu.com/Process/Merges/TestPlans/libreoffice

  [Regression Potential]

   * A minor release with a total of 116 bug fixes always carries the
  potential for introducing regressions, even though it is a bugfix-only
  release, meaning that no new features were added, and no existing
  features were removed.

   * A combination of autopkgtests and careful smoke testing as
  described above should provide reasonable confidence that no
  regressions sneaked in.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/2044019/+subscriptions


-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to