Hi Rico,
Thanks for the nice and detailed SRU template, and all the testing.
While looking at this, particularly the changes in the packaging,
there are a few points that seem to warrant clarification, since
are apparently not related/supporting the upstream bug fixes, or
are not justified as to why included in a SRU (ie, which issues
or bugs are being addressed).
I checked most of these points with Andreas yesterday, and he too
agreed more details would be required before proceeding with this.
Could please address the points below? That's very appreciated.
Thanks again for all the effort on this!
cheers,
Mauricio
...
Changes:
$ debdiff libreoffice_7.6.2-0ubuntu1.dsc
libreoffice_7.6.3-0ubuntu0.23.10.1.dsc | filterdiff -i '*/debian/*'
There are some changes in debian/ that may warrant some clarification
as they do not fit into the SRU policy for minor release updates
(ie, bug-fix only) or to be related to the bugs fixed by upstream
(ie, to support a bug-fix).
I've looked for similarities in the changelog of previous releases,
but apparently haven't found them as precedents. This is the first
time I'm looking at this package, so I might be missing something.
I'll note specific changes in changelog/rules below, for clarity.
1)
d/changelog
18 + - don't try to install dbreport config modules into
19 + -uiconfig-report-builder if the report builder is disabled
d/rules
413 +ifeq "$(ENABLE_REPORTBUILDER)" "y"
414 mv
$(PKGDIR)-common/$(OODIR)/share/config/soffice.cfg/modules/dbreport \
415
$(PKGDIR)-uiconfig-report-builder/$(OODIR)/share/config/soffice.cfg/modules
416 +else
417 + rm -rf
$(PKGDIR)-common/$(OODIR)/share/config/soffice.cfg/modules/dbreport
418 +endif
Is this possibly a separate bug, as apparently it's not related to
an upstream bug fix; it would be nice to have some clarification.
Maybe this is covered in the SRU policy under "it is also acceptable to
upload new microreleases with many bug fixes without individual
Launchpad bugs for each of them", but I considered such 'many bug fixes'
to be related to the upstream bugs, and this change is on packaging.
2)
d/changelog
20 + - switch OOO_BASE_ARCHS/OOO_REPORTBUILDER_ARCHS variables
21 + (build base on all architectures instead of Java architectures
22 + and report-builder-* only on archs where Java is enabled, not on
23 + "all base archs"); there's -sdbc-{mysql,postgresql,firebird} anyway
d/rules
356 -OOO_BASE_ARCHS := $(OOO_JAVA_ARCHS)
357 +OOO_BASE_ARCHS := $(OOO_ARCHS)
358 $(eval $(call gen_no_archs,OOO_BASE_ARCHS))
359 -OOO_REPORTBUILDER_ARCHS := $(OOO_BASE_ARCHS)
360 +OOO_REPORTBUILDER_ARCHS := $(OOO_JAVA_ARCHS)
Similarly; it would be nice to have some clarification,
and perhaps explain the trailing note about '-sdbc-* anyway'.
3)
d/changelog
24 + - don't try to build Jar_{OOoRunner,test,ConnectivityTools} if Java is
25 + disabled as an extra safety net (instead of checking for junit only)
Similary, it would be nice to have some clarification.
d/rules
399 -ifeq "$(BUILD_TEST_PACKAGES)" "y"
400 - ifeq "$(ENABLE_JUNIT4)" "y"
401 +ifeq "$(ENABLE_JAVA)" "y"
402 + ifeq "$(BUILD_TEST_PACKAGES)" "y"
403 + ifeq "$(ENABLE_JUNIT4)" "y"
404 PATH=$(BUILD_PATH) LD_LIBRARY_PATH=$(BUILD_LD_LIBRARY_PATH)
ARCH_FLAGS=$(ARCH_FLAGS) TMP=`mktemp -q -d` $(MAKE) Jar_{OOoRunner,tes
t,ConnectivityTools}
405 + endif
4)
d/changelog
26 + - re-enable cmis; bump libcmis build-dep to >= 0.6.1
Similarly; it would be nice to have some clarification.
And also the reason to enable it in an SRU? Maybe some relation to
an upstream bug or ubuntu bug? Any changes at behavior/runtime?
(apparently just an internal build dep; why is this needed, and
isn't the archive version (older) sufficient?)
d/rules
343 @@ -356,7 +356,7 @@
344 DICT_DIR=/usr/share/hunspell
345 HYPH_DIR=/usr/share/hyphen
346 THES_DIR=/usr/share/mythes
347 -ENABLE_LIBCMIS=n
348 +ENABLE_LIBCMIS=y
386 @@ -1423,7 +1429,7 @@
387 endif
388 ifeq "$(ENABLE_LIBCMIS)" "y"
389 ifneq (,$(filter libcmis, $(SYSTEM_STUFF)))
390 - BUILD_DEPS += , libcmis-dev (>= 0.5.2~), libcmis-dev (<< 0.6~)
391 + BUILD_DEPS += , libcmis-dev (>= 0.6.1~), libcmis-dev (<< 0.7~)
392 endif
393 else
394 CONFIGURE_FLAGS += --disable-libcmis
5)
27 + - build against libcurl4-openssl-dev instead of gnutls
334 @@ -271,7 +271,7 @@
335 USE_GSTREAMER=y
336 endif
337 ENABLE_CURL=y
338 -CURL_SECTYPE=gnutls
339 +CURL_SECTYPE=openssl
Similarly; it would be nice to have some clarification on its reason,
and potential changes to runtime behavior or functionality.
This is a significant change.
6)
30 + * debian/control.ure.in:
31 + - make ure-java actutally Architecture: %OOO_JAVA_ARCHS%
Similarly, it would be nice to have some clarification.
** Changed in: libreoffice (Ubuntu Mantic)
Status: In Progress => Incomplete
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to libreoffice in Ubuntu.
https://bugs.launchpad.net/bugs/2044019
Title:
[SRU] libreoffice 7.6.3 for mantic
Status in libreoffice package in Ubuntu:
Fix Released
Status in libreoffice source package in Mantic:
Incomplete
Bug description:
[Impact]
* LibreOffice 7.6.3 is in its third bugfix release of the 7.6 line:
https://wiki.documentfoundation.org/ReleasePlan/7.6#7.6.3_release
* Version 7.6.2 is currently released in mantic. For a list of fixed bugs
compared to 7.6.2 see the list of bugs fixed in the release candidates of 7.6.3
(that's a total of 116 bugs):
https://wiki.documentfoundation.org/Releases/7.6.3/RC1#List_of_fixed_bugs
https://wiki.documentfoundation.org/Releases/7.6.3/RC2#List_of_fixed_bugs
7.6.3 RC2 is identical to the 7.6.3 release
* Given the nature of the project, the complexity of the codebase and
the high level of quality assurance upstream, it is preferable to SRU
a minor release rather than cherry-pick selected bug fixes.
[Testing]
* Upstream testing. Bugs fixed upstream typically include
unit/regression tests, and the release itself is extensively exercised
(both in an automated manner and manually).
* A recent set of upstream's automated jenkins testing can be found here:
https://ci.libreoffice.org/job/gerrit_76/1459/
* More information about the upstream QA testing can be found here:
* Automated tests
https://wiki.documentfoundation.org/QA/Testing/Automated_Tests
* Automated UI tests
https://wiki.documentfoundation.org/Development/UITests
* Regression tests
https://wiki.documentfoundation.org/QA/Testing/Regression_Tests
* Feature tests
https://wiki.documentfoundation.org/QA/Testing/Feature_Tests
* Launchpad testing. The libreoffice packages include autopkgtests that were
run and verified as passing.
Tested build can be found at
https://launchpad.net/~libreoffice/+archive/ubuntu/libreoffice-prereleases/+sourcepub/15393176/+listing-archive-extra
* [amd64]
https://autopkgtest.ubuntu.com/results/autopkgtest-mantic-libreoffice-libreoffice-prereleases/mantic/amd64/libr/libreoffice/20231123_103407_283ac@/log.gz
* [arm64]
https://autopkgtest.ubuntu.com/results/autopkgtest-mantic-libreoffice-libreoffice-prereleases/mantic/arm64/libr/libreoffice/20231124_182414_cb6a2@/log.gz
* [armhf]
https://autopkgtest.ubuntu.com/results/autopkgtest-mantic-libreoffice-libreoffice-prereleases/mantic/armhf/libr/libreoffice/20231123_114914_bf535@/log.gz
* [ppc64el]
https://autopkgtest.ubuntu.com/results/autopkgtest-mantic-libreoffice-libreoffice-prereleases/mantic/ppc64el/libr/libreoffice/20231123_150619_c4055@/log.gz
* [riscv64] not available
* [s390x]
https://autopkgtest.ubuntu.com/results/autopkgtest-mantic-libreoffice-libreoffice-prereleases/mantic/s390x/libr/libreoffice/20231123_122430_41ff2@/log.gz
* General smoke testing of all the applications in the office suite were
carried out by going through the manual testplan as documented by:
https://wiki.ubuntu.com/Process/Merges/TestPlans/libreoffice
[Regression Potential]
* A minor release with a total of 116 bug fixes always carries the
potential for introducing regressions, even though it is a bugfix-only
release, meaning that no new features were added, and no existing
features were removed.
* A combination of autopkgtests and careful smoke testing as
described above should provide reasonable confidence that no
regressions sneaked in.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/2044019/+subscriptions
--
Mailing list: https://launchpad.net/~desktop-packages
Post to : [email protected]
Unsubscribe : https://launchpad.net/~desktop-packages
More help : https://help.launchpad.net/ListHelp
