On Mon, 2004-03-08 at 22:23, Branden Robinson wrote: > retitle 236334 xserver-xfree86: [i810] driver needs better agpgart error > message for Linux 2.6 users > severity 236334 minor > tag 236334 + upstream patch > thanks > > On Sat, Mar 06, 2004 at 10:01:50PM +0100, Christian Guggenberger wrote: > > On Sat, 2004-03-06 at 21:28, Jason Dorje Short wrote: > > > I mean the error messages from my original report. They say "make sure > > > your kernel is using the agpgart module", when in fact the kernel is > > > using this module and the problem is that's not enough. A better > > > message might be something like "make sure your kernel is using the > > > agpgart module. Under kernel 2.6 and higher, you'll need to use a > > > chipset-specific AGP module as well." This would have been sufficient > > > for me to find and fix the problem on my own. > > > > > That's a good idea, isn't it? > > Branden, what do think? > > > Is it possible to include this in Xfree86 sources, or would it be safer, > > to just put it in Debian's X faq ? > > People don't read the FAQ. Better to improve the driver's error > message. > > Any comments on the attached patch? It would be nice if someone would > apply this patch and test it -- as you'll recall, I don't have easy > access to an x86 box for build testing.
you might want to improve the patch a little bit - we definitly have an intel agp chip, so print out the actual name of the chipset specific agp module in linux-2.6, too : intel-agp.ko - Christian
