Gerfried Fuchs wrote:
> * Martin Schulze <[EMAIL PROTECTED]> [2003-01-17 21:57]:
> > What about this patch and the attached script?
> >
> > @@ -14,3 +15,10 @@
> >
> > %.$(LANGUAGE).html: %.wml $(TEMPLDIR)/event.wml
> > $(WML) $(<F)
> > +
> > +Makefile.reports:
> > + $(ENGLISHSRCDIR)/events/make_makefile_reports.pl
> > $(ENGLISHSRCDIR)/$(CUR_DIR)
^
$(LANG) was missing there
> Shouldn't Makefile.reports depend on something? Is it possible to use
> wildchars there? Like:
>
> Makefile.reports: $(ENGLISHDIR)/events/2002/*-report.wml
Add *-report.wml for the local ones, should work, I guess.
> ... and also with $LANGDIR or what that is called if current language
> is != english. Or doesn't that work? That way we won't have to add a
> generation of the Makefile.reports into the cronjobs. Ah, now it comes
> to my mind that this won't work unless there is at least one
> *-report.wml file... Stupid thing.
Oh, small bug in the script:
if ($LANG ne 'en' && $#ARGV > -1) {
That way it distinguishes between english and !english.
> > It does not yet scan for the defined report, but that can be added
> > quite easily.
>
> Makefile must not scan for defined reports, must it? And the event
> page must not depend on itself for it will be regenerated anyway when
> you edit it ,)
Hmm, of course not, stupid me. Hmm, the index.*.html:... rule is
bogus since index.wml already depends on *.wml. That simplifies
things a little bit.
> > If you want to have it in the <ul> at the end, that's a little bit more
> > tricky, but doable as well. :-)
>
> There's no need to do it, my intention was to have it in the list at
> the top anyway.
Great.
> > If there is, modify the <ul> to write "<ul>\n<li>..." when the source
> > file contains the string "<ul>". You'll just have to redefine <ul>
> > and refer to <ul*> for the original.
>
> Ah, right, of course. But that might interfere with other used <ul>
> that might happen to appear on the events pages. Like in
> /events/2001/1115-hispalinux.wml :)
Simply forbid them, or use something else, whatever. :)
So... are you going to commit your code and I should with mine and see
whether it works as expected?
Gruesse,
Joey
--
The MS-DOS filesystem is nice for removable media. -- H. Peter Anvin
